[ui] Show a delayed loading spinner on Overview search inputs #16607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit a99a54f. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit a99a54f. |
salazarm
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Show a delayed loading spinner on Overview search inputs to inform the user that the workspace is still loading. This way, when they attempt a search that comes up empty, there will be an obvious reason for it: the workspace isn't ready yet.
I added a utility hook to
ui-componentsfor a delayed state update, which will allow us to wait briefly before showing the spinner. This prevents a quick flash of the spinner in cases where the workspace loads fairly quickly. I'll use the utility in a couple of places in Cloud that I've done this in recently.How I Tested These Changes
View Overview, verify that spinners appear after a brief delay when the loading state is forced to be true.
Storybook example for the utility hook.