[1/n] Asset graph sidebar #16447
[1/n] Asset graph sidebar #16447
Conversation
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 224dedd. |
|
This is so exciting |
|
It's important to test a massive fan-in case and see how it performs. |
|
Added indent colors to make it easier to discern siblings/parents of a node at a glance. 
|
|
@schrockn Will test right now, waiting for the asset graph to render though.
|
|
Is it possible for us to hide the asset graph when there are too many nodes, but still use this to navigate the asset graph? Maybe we only show direct upstreams/downstreams of the currently selected node and gradually reveal more as you navigate around |
Yeah that is what I was imagining too as a next step! |
|
@schrockn This is what it looks like with huge fan out https://www.loom.com/share/4629b7700ca0474185f70bfaee745160 |
Added the popover to view upstream/downstream assets. We'll probably add more menu options here for giving more fine grained control to what's visible in the graph too. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 224dedd. |
|
Re: The slow asset graph we're thinking we can either fallback to a less pretty but much faster / virtualizable layout algorithm for large asset graphs. Or porting the layout algorithm to wasm something similar to https://cprimozic.net/blog/speeding-up-webcola-with-webassembly/ |
|
Ahh I love it 🙌 ship ship ship! re: asset graph, I think it might make sense to get this fully wired up and see how much it's helpful to have them side by side. Especially if we make the graph use a simpler layout algorithm, it might just be a boxier horizontal version of this vertical presentation? I could see letting this hierarchy go full screen and toggling the graph off entirely. Also curious how this might interact with a graph of asset groups, since those are a bidirectional graph / less of a clean lineage. I'm sure we can figure it out though! |
salazarm
force-pushed
the
salazarm/asset-sidebar
branch
from
32d2f5b to
cb3353d
Compare
|
I think this could be absolutely transformative for observability and cataloging use cases. However I definitely want @braunjj to approve and slot this into a broader vision for navigation, and then make sure we aren't making any decisions here that we will regret. |
|
Here is the latest that we have: https://www.loom.com/share/Asset-Graph-Sidebar-Update-c8d04bf35dd84e26a43b98a8b0be645d |
I am also very excited about this @schrockn and I'm working on exploring how this fits into a broader vision for the asset catalog and nav. Going to share a Loom later today. Let's plan to focus on this in Core-UI sync on monday. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-k6haqfwdo-elementl.vercel.app Direct link to changed pages: |
|
I also see no reason why this couldn't be the interface to the asset catalog. Just make the right hand pane the asset details page. |
salazarm
force-pushed
the
salazarm/asset-sidebar
branch
from
518c1e9 to
02bf6ce
Compare
salazarm
changed the title
js_modules/dagster-ui/packages/ui-components/src/components/MiddleTruncate.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-graph/AssetGraphExplorer.tsx
Outdated
Show resolved
Hide resolved
## Summary & Motivation Consolidate the group and code location filters to use our Filtering component. ## How I Tested These Changes <img width="335" alt="Screenshot 2023-09-15 at 1 50 53 AM" src="https://github.com/dagster-io/dagster/assets/2286579/88cafb9d-1854-4cc3-90e9-d6dc8b203c03"> <img width="379" alt="Screenshot 2023-09-15 at 1 50 47 AM" src="https://github.com/dagster-io/dagster/assets/2286579/ac918cf6-b0b4-4854-8991-4e48e90a0293"> <img width="289" alt="Screenshot 2023-09-15 at 1 50 45 AM" src="https://github.com/dagster-io/dagster/assets/2286579/12942df9-358a-4ab3-ac7d-cdad1360bcb4">
## Summary & Motivation https://www.loom.com/share/647d76108782411f8ef1c9b06f55eae5 This adds a sidebar to the left of the asset graph that makes it easier to navigate the asset graph without needing to scroll around. This is useful for cases where the asset graph is very large and it's hard to see the ancestors / descendants of a particular asset. It would be nice if we could figure out how to combine this with the existing asset graph sidebar that shows up on the right side somehow so that there's only one sidebar. I put minimal effort into the design for now since this is just a prototype I built to demonstrate one solution to the problem of navigating large asset graphs. Looking for input as to whether we should pursue this direction or not.
Summary & Motivation
https://www.loom.com/share/647d76108782411f8ef1c9b06f55eae5
This adds a sidebar to the left of the asset graph that makes it easier to navigate the asset graph without needing to scroll around. This is useful for cases where the asset graph is very large and it's hard to see the ancestors / descendants of a particular asset.
It would be nice if we could figure out how to combine this with the existing asset graph sidebar that shows up on the right side somehow so that there's only one sidebar.
I put minimal effort into the design for now since this is just a prototype I built to demonstrate one solution to the problem of navigating large asset graphs. Looking for input as to whether we should pursue this direction or not.