[externals] Remove IO modes entirely #16008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
smackesey
force-pushed
the
sean/externals-remove-io-modes
branch
from
d4956a1 to
d8c427e
Compare
sirawats
pushed a commit
to sirawats/dagster
that referenced
this pull request
Aug 24, 2023
## Summary & Motivation Removes IO modes entirely from `dagster-external`, standardizing on the use of temporary files for IPC. ## How I Tested These Changes Existing test suite (though many tests have been deleted).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Removes IO modes entirely from
dagster-external, standardizing on the use of temporary files for IPC.How I Tested These Changes
Existing test suite (though many tests have been deleted).