-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Summary & Motivation Cleanup of our entire icon library - adds a bunch of new icons - replaced a bunch of old ones so that all icons have the same line width and style - Many of the new icons were added to help power the new icon picker in Dagster+ ![image](https://github.com/user-attachments/assets/d3732cac-989f-4728-8234-db544dcbef34) Note: there are a few duplicate icons (same icon under two different names). I did this to preserve all the existing icon names while also introducing more logical icon names to use moving forward. All these icons are also reflected in Figma, so now design and dev now match exactly. ### Future Plans - Once merged, I'm going to update the icon pack in the Dagster+ Icon selector component that @benpankow built which is used in Insights and Catalog Views. - I'd like to refactor and generalize the `Compute_Kind` icons since we are now using them for more than just `compute_kind`. I think these all branded tool/service icons should live alongside our default icon pack. This way we only have one standard icon pack that includes all the UI icons and branded compute kind/storage kind icons. Every branded icon will come in a `flat` and `color` variant. I am working on a large set of new branded icons that you can preview below and will ship this in a follow up PR. ![image](https://github.com/user-attachments/assets/245b91e8-cda1-4d8b-94b7-5691021f82b4) ## How I Tested These Changes Booted up the UI
- Loading branch information
Showing
402 changed files
with
1,734 additions
and
857 deletions.
There are no files selected for viewing
450 changes: 325 additions & 125 deletions
450
js_modules/dagster-ui/packages/ui-components/src/components/Icon.tsx
Large diffs are not rendered by default.
Oops, something went wrong.
11 changes: 10 additions & 1 deletion
11
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/account_circle.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion
4
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/account_tree.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion
4
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/add.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion
4
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/add_circle.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/agent.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/alert.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 10 additions & 1 deletion
11
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/alternate_email.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/approved.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion
4
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/arrow_back.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion
4
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/arrow_downward.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion
4
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/arrow_drop_down.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion
4
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/arrow_forward.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 3 additions & 10 deletions
13
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/arrow_indent.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion
4
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/arrow_upward.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 2 additions & 4 deletions
6
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/asset.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 3 additions & 8 deletions
11
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/asset_check.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions
11
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/asset_external.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion
2
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/asset_group.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions
4
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/asset_legacy.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 4 additions & 12 deletions
16
js_modules/dagster-ui/packages/ui-components/src/icon-svgs/asset_non_sda.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
f8832fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-storybook ready!
✅ Preview
https://dagit-storybook-4fpl8i87y-elementl.vercel.app
Built with commit f8832fc.
This pull request is being automatically deployed with vercel-action