Skip to content

Commit

Permalink
Icon Revamp (#23255)
Browse files Browse the repository at this point in the history
## Summary & Motivation
Cleanup of our entire icon library
- adds a bunch of new icons
- replaced a bunch of old ones so that all icons have the same line
width and style
- Many of the new icons were added to help power the new icon picker in
Dagster+


![image](https://github.com/user-attachments/assets/d3732cac-989f-4728-8234-db544dcbef34)

Note: there are a few duplicate icons (same icon under two different
names). I did this to preserve all the existing icon names while also
introducing more logical icon names to use moving forward.

All these icons are also reflected in Figma, so now design and dev now
match exactly.

### Future Plans
- Once merged, I'm going to update the icon pack in the Dagster+ Icon
selector component that @benpankow built which is used in Insights and
Catalog Views.
- I'd like to refactor and generalize the `Compute_Kind` icons since we
are now using them for more than just `compute_kind`. I think these all
branded tool/service icons should live alongside our default icon pack.
This way we only have one standard icon pack that includes all the UI
icons and branded compute kind/storage kind icons. Every branded icon
will come in a `flat` and `color` variant. I am working on a large set
of new branded icons that you can preview below and will ship this in a
follow up PR.

![image](https://github.com/user-attachments/assets/245b91e8-cda1-4d8b-94b7-5691021f82b4)


## How I Tested These Changes
Booted up the UI
  • Loading branch information
braunjj authored Aug 16, 2024
1 parent 3aea9e7 commit f8832fc
Show file tree
Hide file tree
Showing 402 changed files with 1,734 additions and 857 deletions.
450 changes: 325 additions & 125 deletions js_modules/dagster-ui/packages/ui-components/src/components/Icon.tsx

Large diffs are not rendered by default.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

1 comment on commit f8832fc

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-4fpl8i87y-elementl.vercel.app

Built with commit f8832fc.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.