-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Fix unnecessary middle truncation occurring in dialogs (#26086)
## Summary & Motivation https://linear.app/dagster-labs/issue/FE-684/targeted-assets-dialog-is-too-aggressive-with-middle-truncate Thankfully this turned out to be a quick fix - I verified in the docs that `offsetWidth` shouldn't have other implications beyond this: <img width="754" alt="image" src="https://github.com/user-attachments/assets/000c76f6-cfcb-4a47-a83b-2436b18acc8b"> ## How I Tested These Changes Tested manually in the "Upstream assets modal" with some long asset names and also via a new storybook + verification that no other MiddleTruncate storybooks were impacted. <img width="371" alt="image" src="https://github.com/user-attachments/assets/35fa3889-9609-46a4-9ca3-303464b70494"> ## Changelog [ui] Fixed unnecessary middle truncation occurring in dialogs. Co-authored-by: bengotow <[email protected]>
- Loading branch information
Showing
5 changed files
with
39 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d298e05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-storybook ready!
✅ Preview
https://dagit-storybook-htadh7ohk-elementl.vercel.app
Built with commit d298e05.
This pull request is being automatically deployed with vercel-action
d298e05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-5g7m23aou-elementl.vercel.app
Built with commit d298e05.
This pull request is being automatically deployed with vercel-action