Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Align “Lauched run / backfill” toasts — cmd-click to open in new…
… tab (#15965) ## Summary & Motivation Fixes #15929 This PR slightly adjusts the behavior of the "Launched run" toasts in dagster UI to be consistent with the launched backfill toasts. The new behavior is: - Click "View" => opens in same tab - Cmd-click "View" => opens in new tab Depending on the browser and your settings the new tab may open behind the current one. In Firefox, cmd-shift-click makes a separate tab and foregrounds it, which aligns with the previous behavior. We believe this approach offers the most flexibility because users can use the standard keyboard shortcuts to get the behavior they want. ## How I Tested These Changes I tested this by creating runs and backfills and clicking the toasts in both ways. ## Prior Art There have been several discussions of this behavior over the last year or two: - https://elementl-workspace.slack.com/archives/C03CCE471E0/p1664470710262119 - https://elementl-workspace.slack.com/archives/C03CCE471E0/p1692298385801809 Co-authored-by: bengotow <[email protected]>
- Loading branch information
a11a28d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-nvsasolom-elementl.vercel.app
Built with commit a11a28d.
This pull request is being automatically deployed with vercel-action