update canceling logic

dagster-io · Nov 25, 2024 · 87d88c8 · 87d88c8
1 parent 32b5499
commit 87d88c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/python_modules/dagster/dagster/_core/definitions/asset_graph_subset.py b/python_modules/dagster/dagster/_core/definitions/asset_graph_subset.py
@@ -242,12 +242,6 @@ def __repr__(self) -> str:
             ")"
         )
 
-    @classmethod
-    def empty(cls):
-        return AssetGraphSubset(
-            partitions_subsets_by_asset_key={}, non_partitioned_asset_keys=set()
-        )
-
     @classmethod
     def from_asset_partition_set(
         cls,

diff --git a/python_modules/dagster/dagster/_core/execution/asset_backfill.py b/python_modules/dagster/dagster/_core/execution/asset_backfill.py
@@ -1290,7 +1290,7 @@ def get_canceling_asset_backfill_iteration_data(
                 instance_queryer,
                 backfill_id,
                 asset_graph,
-                materialized_subset=AssetGraphSubset.empty(),
+                materialized_subset=updated_materialized_subset,
             )
         ),
         asset_graph,
@@ -1300,8 +1300,7 @@ def get_canceling_asset_backfill_iteration_data(
         latest_storage_id=asset_backfill_data.latest_storage_id,
         requested_runs_for_target_roots=asset_backfill_data.requested_runs_for_target_roots,
         materialized_subset=updated_materialized_subset,
-        failed_and_downstream_subset=asset_backfill_data.failed_and_downstream_subset
-        | failed_subset,
+        failed_and_downstream_subset=failed_subset,
         requested_subset=asset_backfill_data.requested_subset,
         backfill_start_time=TimestampWithTimezone(backfill_start_timestamp, "UTC"),
     )