Skip to content

Commit

Permalink
small
Browse files Browse the repository at this point in the history
  • Loading branch information
jamiedemaria committed Nov 13, 2024
1 parent ca6b31a commit 6f60763
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ def backfill_is_complete(
if (
# Condition 1 - all asset partitions in the target subset have a materialization state
backfill_data.all_targeted_partitions_have_materialization_status()
# Condtition 2 - there are no in progress runs for the backfill
# Condition 2 - there are no in progress runs for the backfill
and len(
instance.get_run_ids(
filters=RunsFilter(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2868,11 +2868,12 @@ def test_asset_backfill_not_complete_until_retries_complete(
list(execute_backfill_iteration(workspace_context, get_default_daemon_logger("BackfillDaemon")))
backfill = instance.get_backfill(backfill_id)
assert backfill
assert backfill.asset_backfill_data
assert backfill.asset_backfill_data.all_targeted_partitions_have_materialization_status()
assert backfill.status == BulkActionStatus.REQUESTED

# manually mark the run as successful to show that the backfill will be marked as complete
# since there are no in prgress runs
# since there are no in progress runs
instance.handle_new_event(
EventLogEntry(
error_info=None,
Expand Down Expand Up @@ -2943,6 +2944,7 @@ def test_asset_backfill_not_complete_if_automatic_retry_could_happen(
list(execute_backfill_iteration(workspace_context, get_default_daemon_logger("BackfillDaemon")))
backfill = instance.get_backfill(backfill_id)
assert backfill
assert backfill.asset_backfill_data
assert backfill.asset_backfill_data.all_targeted_partitions_have_materialization_status()
assert backfill.status == BulkActionStatus.REQUESTED

Expand Down

0 comments on commit 6f60763

Please sign in to comment.