doc strings, some cleanup

dagster-io · Sep 6, 2023 · 658e8c4 · 658e8c4
1 parent 9c7ac93
commit 658e8c4
Show file tree

Hide file tree

Showing 9 changed files with 333 additions and 40 deletions.
diff --git a/docs/content/api/modules.json b/docs/content/api/modules.json
diff --git a/docs/content/api/searchindex.json b/docs/content/api/searchindex.json
diff --git a/docs/content/api/sections.json b/docs/content/api/sections.json
diff --git a/docs/next/public/objects.inv b/docs/next/public/objects.inv
diff --git a/python_modules/dagster/dagster/_core/execution/context/compute.py b/python_modules/dagster/dagster/_core/execution/context/compute.py
diff --git a/python_modules/dagster/dagster/_core/execution/context/system.py b/python_modules/dagster/dagster/_core/execution/context/system.py
@@ -1359,7 +1359,10 @@ def asset_partitions_time_window_for_asset(
         asset_layer = self.job_def.asset_layer
         asset_key = AssetKey.from_coercible(asset)
 
-        if not asset_layer.has_assets_def_for_asset(asset_key):
+        if (
+            not asset_layer.has_assets_def_for_asset(asset_key)
+            and asset_layer.source_assets_by_key.get(asset_key, None) is None
+        ):
             raise ValueError("The provided asset key does not correspond to an asset.")
 
         asset_partitions_def = asset_layer.partitions_def_for_asset(asset_key)

diff --git a/python_modules/dagster/dagster_tests/asset_defs_tests/test_decorators.py b/python_modules/dagster/dagster_tests/asset_defs_tests/test_decorators.py
@@ -49,12 +49,12 @@
 from dagster._core.types.dagster_type import resolve_dagster_type
 
 
-# @pytest.fixture(autouse=True)
-# def error_on_warning():
-#     # turn off any outer warnings filters, e.g. ignores that are set in pyproject.toml
-#     warnings.resetwarnings()
+@pytest.fixture(autouse=True)
+def error_on_warning():
+    # turn off any outer warnings filters, e.g. ignores that are set in pyproject.toml
+    warnings.resetwarnings()
 
-#     warnings.filterwarnings("error")
+    warnings.filterwarnings("error")
 
 
 def test_asset_no_decorator_args():

diff --git a/python_modules/dagster/dagster_tests/asset_defs_tests/test_materialize.py b/python_modules/dagster/dagster_tests/asset_defs_tests/test_materialize.py
@@ -31,12 +31,12 @@
 from dagster._core.test_utils import ignore_warning, instance_for_test
 
 
-# @pytest.fixture(autouse=True)
-# def error_on_warning():
-#     # turn off any outer warnings filters, e.g. ignores that are set in pyproject.toml
-#     warnings.resetwarnings()
+@pytest.fixture(autouse=True)
+def error_on_warning():
+    # turn off any outer warnings filters, e.g. ignores that are set in pyproject.toml
+    warnings.resetwarnings()
 
-#     warnings.filterwarnings("error")
+    warnings.filterwarnings("error")
 
 
 def test_basic_materialize():

diff --git a/python_modules/dagster/dagster_tests/asset_defs_tests/test_partitioned_assets.py b/python_modules/dagster/dagster_tests/asset_defs_tests/test_partitioned_assets.py
@@ -40,12 +40,12 @@
 from dagster._seven.compat.pendulum import create_pendulum_time
 
 
-# @pytest.fixture(autouse=True)
-# def error_on_warning():
-#     # turn off any outer warnings filters, e.g. ignores that are set in pyproject.toml
-#     warnings.resetwarnings()
+@pytest.fixture(autouse=True)
+def error_on_warning():
+    # turn off any outer warnings filters, e.g. ignores that are set in pyproject.toml
+    warnings.resetwarnings()
 
-#     warnings.filterwarnings("error")
+    warnings.filterwarnings("error")
 
 
 def get_upstream_partitions_for_partition_range(