Use LoadingContextForTest

dagster-io · Oct 22, 2024 · 45d68da · 45d68da
1 parent da94d72
commit 45d68da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/python_modules/dagster/dagster/_core/loader.py b/python_modules/dagster/dagster/_core/loader.py
@@ -58,10 +58,6 @@ def instance(self) -> "DagsterInstance":
     def loaders(self) -> Dict[Type, Tuple[DataLoader, BlockingDataLoader]]:
         raise NotImplementedError()
 
-    @staticmethod
-    def ephemeral(instance: "DagsterInstance") -> "LoadingContext":
-        return LoadingContextForTest(instance)
-
     def get_loaders_for(
         self, ttype: Type["InstanceLoadableBy"]
     ) -> Tuple[DataLoader, BlockingDataLoader]:

diff --git a/python_modules/dagster/dagster_tests/storage_tests/utils/event_log_storage.py b/python_modules/dagster/dagster_tests/storage_tests/utils/event_log_storage.py
@@ -83,7 +83,7 @@
 from dagster._core.execution.plan.objects import StepFailureData, StepSuccessData
 from dagster._core.execution.stats import StepEventStatus
 from dagster._core.instance import RUNLESS_JOB_NAME, RUNLESS_RUN_ID
-from dagster._core.loader import LoadingContext
+from dagster._core.loader import LoadingContextForTest
 from dagster._core.remote_representation.external_data import PartitionsSnap
 from dagster._core.remote_representation.origin import (
     InProcessCodeLocationOrigin,
@@ -6025,7 +6025,7 @@ def test_get_updated_asset_status_cache_values(
         }
 
         assert storage.get_asset_status_cache_values(
-            partition_defs_by_key, LoadingContext.ephemeral(instance)
+            partition_defs_by_key, LoadingContextForTest(instance)
         ) == [
             None,
             None,
@@ -6043,7 +6043,7 @@ def test_get_updated_asset_status_cache_values(
         partition_defs = list(partition_defs_by_key.values())
         for i, value in enumerate(
             storage.get_asset_status_cache_values(
-                partition_defs_by_key, LoadingContext.ephemeral(instance)
+                partition_defs_by_key, LoadingContextForTest(instance)
             ),
         ):
             assert value is not None