fix internal asset deps resolution

dagster-io · Aug 31, 2023 · 33be378 · 33be378
1 parent 5145a3b
commit 33be378
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/python_modules/dagster/dagster/_core/definitions/decorators/asset_decorator.py b/python_modules/dagster/dagster/_core/definitions/decorators/asset_decorator.py
@@ -627,7 +627,7 @@ def inner(fn: Callable[..., Any]) -> AssetsDefinition:
                 dep.asset_key
                 for spec in specs
                 for dep in spec.deps
-                if dep not in output_tuples_by_asset_key
+                if dep.asset_key not in output_tuples_by_asset_key
             }
 
             explicit_ins = ins or {}

diff --git a/python_modules/dagster/dagster_tests/asset_defs_tests/test_assets.py b/python_modules/dagster/dagster_tests/asset_defs_tests/test_assets.py
@@ -1922,19 +1922,6 @@ def test_asset_spec_deps():
     def table_A():
         pass
 
-    # TODO - remove, here for debug
-    @multi_asset(
-        outs={"a": AssetOut(), "b": AssetOut(), "c": AssetOut()},
-        internal_asset_deps={
-            "a": {AssetKey("in1"), AssetKey("in2")},
-            "b": set(),
-            "c": {AssetKey("a"), AssetKey("b"), AssetKey("in2"), AssetKey("in3")},
-        },
-        can_subset=True,
-    )
-    def abc_(context, in1, in2, in3):
-        pass
-
     table_b = AssetSpec("table_B", deps=[table_A])
     table_c = AssetSpec("table_C", deps=[table_A, table_b])
     table_b_no_dep = AssetSpec("table_B")