Skip to content

Commit

Permalink
[dagster-airlift] Fix dbt example tests (#25778)
Browse files Browse the repository at this point in the history
## Summary & Motivation
We weren't constructing env correctly, which was causing tests to fail. This fixed for me locally.
  • Loading branch information
dpeng817 authored Nov 7, 2024
1 parent 981e204 commit 30deebb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -368,11 +368,10 @@ def k8s_extra_cmds(version: str, _) -> List[str]:
PackageSpec(
"examples/experimental/dagster-airlift",
),
# Skipping for now due to flaky integration tests.
# PackageSpec(
# "examples/experimental/dagster-airlift/examples/dbt-example",
# always_run_if=has_dagster_airlift_changes,
# ),
PackageSpec(
"examples/experimental/dagster-airlift/examples/dbt-example",
always_run_if=has_dagster_airlift_changes,
),
PackageSpec(
"examples/experimental/dagster-airlift/examples/perf-harness",
always_run_if=has_dagster_airlift_changes,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ setup_local_env:
mkdir -p $(MIGRATING_AIRFLOW_HOME)
mkdir -p $(DAGSTER_HOME)
chmod +x ../../scripts/airflow_setup.sh
../../scripts/airflow_setup.sh $(MAKEFILE_DIR)/dbt_example/migrating_airflow_dags $(MIGRATING_AIRFLOW_HOME)
AIRFLOW_HOME=$(MIGRATING_AIRFLOW_HOME) ../../scripts/airflow_setup.sh $(MAKEFILE_DIR)/dbt_example/migrating_airflow_dags
$(MAKE) dbt_setup

not_proxied:
Expand Down Expand Up @@ -57,7 +57,7 @@ run_complete:
dagster dev -m dbt_example.dagster_defs.complete -p 3333

wipe: ## Wipe out all the files created by the Makefile
rm -rf $(AIRFLOW_HOME) $(DAGSTER_HOME)
rm -rf $(MIGRATING_AIRFLOW_HOME) $(DAGSTER_HOME)

wipe_dagster: ## Wipe out all the files created by the Makefile
rm -rf $$DAGSTER_HOME

0 comments on commit 30deebb

Please sign in to comment.