Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step for acr #17

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Add step for acr #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91194a2
Add step for acr
dpeng817 Nov 27, 2024
5a3490e
Use env var
dpeng817 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/dagster-cloud-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,16 @@ jobs:
# username: _json_key
# password: ${{ secrets.GCR_JSON_KEY }}

# # Azure Container Registry (ACR)
# # https://github.com/docker/login-action#azure-container-registry-acr
# - name: Login to Azure Container Registry
# if: steps.prerun.outputs.result != 'skip'
# uses: docker/login-action@v3
# with:
# registry: ${{ env.IMAGE_REGISTRY }}
# username: ${{ secrets.AZURE_CLIENT_ID }}
# password: ${{ secrets.AZURE_CLIENT_SECRET }}

# Build the "quickstart_etl" location.
# For each code location, the "build-push-action" builds the docker
# image and a "set-build-output" command records the image tag for each code location.
Expand Down
Loading