Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going though dependencies, it looks like the
sprintf
dependency are not really justified based on the functionality being used of this package. I therefore suggest removing the package as dependency to reduce the amount of maintenance burden of dart-uuid.I am not entirely sure why this hex converting logic are made like it is since it does not really generate "real" hex values since
2024
are converted to0x2024
and not0x07E8
which would be the correct value when converting `2024´ into hex.To prevent failing tests and potential breaking changes, my implementation will still generate the exact same hex-like values as before the
sprintf
removal. But if we are open for changing this design, I can easily change the logic so we generate the neededUint8List
lists directly from theint
values instead of going though this hex conversions.