Skip to content

Commit

Permalink
Minor todo comment
Browse files Browse the repository at this point in the history
  • Loading branch information
dacort committed Aug 3, 2020
1 parent 659e53a commit 776f9e5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/metabase/driver/athena.clj
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@

;; Required because we're calling our own custom private get-tables method to support Athena
(defn- fast-active-tables [driver, ^DatabaseMetaData metadata, & [db-name-or-nil]]
;; TODO: Catch errors here so a single exception doesn't fail the entire schema
(with-open [rs (.getSchemas metadata)]
(let [all-schemas (set (map :table_schem (jdbc/metadata-result rs)))
schemas (set/difference all-schemas (sql-jdbc.sync/excluded-schemas driver))]
Expand Down

0 comments on commit 776f9e5

Please sign in to comment.