Update Typescript #331
Open
Update Typescript #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvlaarhoven
force-pushed
the
upgrade-typescript
branch
2 times, most recently
from
eec55f2 to
a03332d
Compare
nvlaarhoven
force-pushed
the
upgrade-typescript
branch
from
a03332d to
90739a5
Compare
nvlaarhoven
force-pushed
the
upgrade-typescript
branch
from
873a6f0 to
e93f61e
Compare
JakeSidSmith
suggested changes
Apr 16, 2020
src/ts/types.ts
Outdated
| export interface ComponentProps { | ||
| /** | ||
| * Set the component to render a different element type. | ||
| */ | ||
| component?: string; | ||
| component?: ReactType; |
There was a problem hiding this comment.
This type is deprecated (and I don't think correct). You want an explicit list of available elements really... I can't remember where I've got this from before...
You may be able to use keyof IntrinsicElements or Pick<keyof IntrinsicElements , 'div' | 'span' | 'etc etc'>.
Or just manually define them: div | span | etc etc
tests/index.tsx
Outdated
| @@ -49,7 +49,7 @@ describe('index file', () => { | |||
|
|
|||
| for (const key in index) { | |||
| if (index.hasOwnProperty(key)) { | |||
| const Component = index[key as Keys]; | |||
| const Component = index[key as Keys] as ReactType; | |||
There was a problem hiding this comment.
How come this is necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/FkPWevtY/79-roe-typescript-upgrade
react-docgen-typescriptcomponentNote: Not related to TS upgrade, but also added whitespace to group imports