278 inputgroup flexbox #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 25, 2018 10:07
src/less/inputs.less
Outdated
| border-radius: 0; | ||
| } | ||
| & > * { // lesshint universalSelector: false | ||
| display: inline-block; |
There was a problem hiding this comment.
I think swapping this for inline-flex might fix it in IE9-10.
There was a problem hiding this comment.
no because this is a selector for the children, not the parent. inline-block is fine, and is overridden by the flex declaration on the parent. Have now fixed all IE alignment issues FTW 👍
added 4 commits
September 26, 2018 12:29
progressively enhance, and means we can override the widths for IE. works for buttons and div.buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converting input group to use flexbox with a
display: tablefallback.