Merge pull request #297 from dabapps/Set-overflow-to-null-instead-of-…

…initial-to-support-IE11

Set overflow to null instead of initial to support IE

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dabapps/roe",
-  "version": "0.9.24",
+  "version": "0.9.25",
   "description": "A collection of React components, styles, mixins, and atomic CSS classes to aid with the development of web applications.",
   "main": "dist/js/index.js",
   "types": "dist/js/index.d.ts",

src/ts/components/misc/collapse.tsx

@@ -151,7 +151,7 @@ export class Collapse extends PureComponent<CollapseProps, CollapseState> {
       minHeight,
       maxHeight: opened ? null : height,
       position: 'relative' as 'relative',
-      overflow: (!opened ? 'hidden' : 'initial') as 'hidden' | 'initial',
+      overflow: (opened ? null : 'hidden') as 'hidden' | null,
       transition: `ease-in-out ${animationDuration}ms max-height`,
     };
 

tests/__snapshots__/collapse.tsx.snap

@@ -72,7 +72,7 @@ exports[`Collapse should close to custom height 1`] = `
       Object {
         "maxHeight": null,
         "minHeight": null,
-        "overflow": "initial",
+        "overflow": null,
         "position": "relative",
         "transition": "ease-in-out 200ms max-height",
       }
@@ -200,7 +200,7 @@ exports[`Collapse should close to default height 1`] = `
       Object {
         "maxHeight": null,
         "minHeight": null,
-        "overflow": "initial",
+        "overflow": null,
         "position": "relative",
         "transition": "ease-in-out 200ms max-height",
       }
@@ -336,7 +336,7 @@ exports[`Collapse should match snapshot when expanded 1`] = `
     Object {
       "maxHeight": null,
       "minHeight": null,
-      "overflow": "initial",
+      "overflow": null,
       "position": "relative",
       "transition": "ease-in-out 200ms max-height",
     }
@@ -554,7 +554,7 @@ exports[`Collapse should open from custom height 4`] = `
       Object {
         "maxHeight": null,
         "minHeight": null,
-        "overflow": "initial",
+        "overflow": null,
         "position": "relative",
         "transition": "ease-in-out 200ms max-height",
       }
@@ -679,7 +679,7 @@ exports[`Collapse should open from default height 4`] = `
       Object {
         "maxHeight": null,
         "minHeight": null,
-        "overflow": "initial",
+        "overflow": null,
         "position": "relative",
         "transition": "ease-in-out 200ms max-height",
       }