Revert "Send Notification to a URL on proposal created (#877)"

This reverts commit 489c5a3.
dOrgTech · Dec 16, 2024 · efbf223 · efbf223
1 parent 489c5a3
commit efbf223
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 82 deletions.
diff --git a/env.example b/env.example
diff --git a/src/services/config/constants.ts b/src/services/config/constants.ts
@@ -18,8 +18,7 @@ export enum EnvKey {
   REACT_APP_BASE_URL = "REACT_APP_BASE_URL",
   REACT_APP_DAO_DEPLOYER_API = "REACT_APP_DAO_DEPLOYER_API",
   REACT_APP_RPC_NETWORK_GHOSTNET = "REACT_APP_RPC_NETWORK_GHOSTNET",
-  REACT_APP_RPC_NETWORK_MAINNET = "REACT_APP_RPC_NETWORK_MAINNET",
-  REACT_APP_PROPOSAL_WEBHOOK_URL = "REACT_APP_PROPOSAL_WEBHOOK_URL"
+  REACT_APP_RPC_NETWORK_MAINNET = "REACT_APP_RPC_NETWORK_MAINNET"
 }
 
 export enum FeatureFlag {

diff --git a/src/services/contracts/baseDAO/hooks/useLambdaAddPropose.ts b/src/services/contracts/baseDAO/hooks/useLambdaAddPropose.ts
@@ -6,7 +6,6 @@ import { useTezos } from "services/beacon/hooks/useTezos"
 import mixpanel from "mixpanel-browser"
 import { networkNameMap } from "../../../bakingBad"
 import { LambdaDAO } from "../lambdaDAO"
-import { sendProposalCreatedEvent } from "services/utils/utils"
 
 export const useLambdaAddPropose = () => {
   const queryClient = useQueryClient()
@@ -42,8 +41,6 @@ export const useLambdaAddPropose = () => {
           daoType: "Registry"
         })
 
-        sendProposalCreatedEvent(network, account, dao.data.name, dao.data.address)
-
         await data.confirmation(1)
         closeProposalNotification(proposalNotification)
         // setProposalDone()
@@ -56,7 +53,6 @@ export const useLambdaAddPropose = () => {
         })
 
         handleClose()
-
         return data
       } catch (e) {
         console.log(e)

diff --git a/src/services/contracts/baseDAO/hooks/useLambdaExecutePropose.ts b/src/services/contracts/baseDAO/hooks/useLambdaExecutePropose.ts
@@ -6,7 +6,6 @@ import { useTezos } from "services/beacon/hooks/useTezos"
 import mixpanel from "mixpanel-browser"
 import { networkNameMap } from "../../../bakingBad"
 import { LambdaDAO } from "../lambdaDAO"
-import { sendProposalCreatedEvent } from "services/utils/utils"
 
 export const useLambdaExecutePropose = () => {
   const queryClient = useQueryClient()
@@ -43,7 +42,6 @@ export const useLambdaExecutePropose = () => {
           dao: dao.data.address,
           daoType: "Registry"
         })
-        sendProposalCreatedEvent(network, account, dao.data.name, dao.data.address)
 
         await data.confirmation(1)
         closeProposalNotification(proposalNotification)

diff --git a/src/services/contracts/baseDAO/hooks/useLambdaRemovePropose.ts b/src/services/contracts/baseDAO/hooks/useLambdaRemovePropose.ts
@@ -6,7 +6,6 @@ import { useTezos } from "services/beacon/hooks/useTezos"
 import mixpanel from "mixpanel-browser"
 import { networkNameMap } from "../../../bakingBad"
 import { LambdaDAO } from "../lambdaDAO"
-import { sendProposalCreatedEvent } from "services/utils/utils"
 
 export const useLambdaRemovePropose = () => {
   const queryClient = useQueryClient()
@@ -41,7 +40,6 @@ export const useLambdaRemovePropose = () => {
           dao: dao.data.address,
           daoType: "Registry"
         })
-        sendProposalCreatedEvent(network, account, dao.data.name, dao.data.address)
 
         await data.confirmation(1)
         closeProposalNotification(proposalNotification)

diff --git a/src/services/contracts/baseDAO/hooks/useProposeConfigChange.ts b/src/services/contracts/baseDAO/hooks/useProposeConfigChange.ts
@@ -5,8 +5,6 @@ import { useTezos } from "services/beacon/hooks/useTezos"
 import { BaseDAO } from "../class"
 import { ConfigProposalParams } from "../types"
 import { networkNameMap } from "../../../bakingBad"
-import { sendProposalCreatedEvent } from "services/utils/utils"
-import mixpanel from "mixpanel-browser"
 
 export const useProposeConfigChange = () => {
   const queryClient = useQueryClient()
@@ -32,12 +30,6 @@ export const useProposeConfigChange = () => {
         }
 
         const data = await dao.proposeConfigChange(args, tezosToolkit)
-        mixpanel.track("Proposal Created", {
-          dao: dao.data.address,
-          daoType: "Registry"
-        })
-        sendProposalCreatedEvent(network, account, dao.data.name, dao.data.address)
-
         await data.confirmation(1)
         closeProposalNotification(proposalNotification)
 

diff --git a/src/services/contracts/baseDAO/hooks/useProposeDelegationChange.ts b/src/services/contracts/baseDAO/hooks/useProposeDelegationChange.ts
@@ -4,8 +4,6 @@ import { useNotification } from "modules/common/hooks/useNotification"
 import { useTezos } from "services/beacon/hooks/useTezos"
 import { BaseDAO } from "../class"
 import { networkNameMap } from "../../../bakingBad"
-import mixpanel from "mixpanel-browser"
-import { sendProposalCreatedEvent } from "services/utils/utils"
 
 export const useProposeDelegationChange = () => {
   const queryClient = useQueryClient()
@@ -31,12 +29,6 @@ export const useProposeDelegationChange = () => {
         }
 
         const data = await dao.proposeDelegationChange(newDelegationAddress, tezosToolkit)
-        mixpanel.track("Proposal Created", {
-          dao: dao.data.address,
-          daoType: "Registry"
-        })
-        sendProposalCreatedEvent(network, account, dao.data.name, dao.data.address)
-
         await data.confirmation(1)
         closeProposalNotification(proposalNotification)
 

diff --git a/src/services/contracts/baseDAO/hooks/useProposeGuardianChange.ts b/src/services/contracts/baseDAO/hooks/useProposeGuardianChange.ts
@@ -4,8 +4,6 @@ import { useNotification } from "modules/common/hooks/useNotification"
 import { useTezos } from "services/beacon/hooks/useTezos"
 import { BaseDAO } from "../class"
 import { networkNameMap } from "../../../bakingBad"
-import { sendProposalCreatedEvent } from "services/utils/utils"
-import mixpanel from "mixpanel-browser"
 
 export const useProposeGuardianChange = () => {
   const queryClient = useQueryClient()
@@ -31,12 +29,6 @@ export const useProposeGuardianChange = () => {
         }
 
         const data = await dao.proposeGuardianChange(newGuardianAddress, tezosToolkit)
-        mixpanel.track("Proposal Created", {
-          dao: dao.data.address,
-          daoType: "Registry"
-        })
-        sendProposalCreatedEvent(network, account, dao.data.name, dao.data.address)
-
         await data.confirmation(1)
         closeProposalNotification(proposalNotification)
 

diff --git a/src/services/contracts/baseDAO/hooks/useRegistryPropose.ts b/src/services/contracts/baseDAO/hooks/useRegistryPropose.ts
@@ -6,7 +6,6 @@ import { useTezos } from "services/beacon/hooks/useTezos"
 import { LambdaDAO } from "../lambdaDAO"
 import mixpanel from "mixpanel-browser"
 import { networkNameMap } from "../../../bakingBad"
-import { sendProposalCreatedEvent } from "services/utils/utils"
 
 export const useRegistryPropose = () => {
   const queryClient = useQueryClient()
@@ -37,7 +36,6 @@ export const useRegistryPropose = () => {
           dao: dao.data.address,
           daoType: "Registry"
         })
-        sendProposalCreatedEvent(network, account, dao.data.name, dao.data.address)
 
         await data.confirmation(1)
         closeProposalNotification(proposalNotification)

diff --git a/src/services/contracts/baseDAO/hooks/useTreasuryPropose.ts b/src/services/contracts/baseDAO/hooks/useTreasuryPropose.ts
@@ -6,7 +6,6 @@ import { RegistryProposeArgs } from "../lambdaDAO/types"
 import mixpanel from "mixpanel-browser"
 import { networkNameMap } from "../../../bakingBad"
 import { LambdaDAO } from "../lambdaDAO"
-import { sendProposalCreatedEvent } from "services/utils/utils"
 
 export const useTreasuryPropose = () => {
   const queryClient = useQueryClient()
@@ -38,7 +37,6 @@ export const useTreasuryPropose = () => {
           dao: dao.data.address,
           daoType: "Treasury"
         })
-        sendProposalCreatedEvent(network, account, dao.data.name, dao.data.address)
 
         await data.confirmation(1)
         closeProposalNotification(proposalNotification)

diff --git a/src/services/utils/utils.ts b/src/services/utils/utils.ts
@@ -250,26 +250,3 @@ export const validateTokenAddress = (network: Network, tokenAddress: string) =>
   if (network.startsWith("etherlink")) return isEtherAddress(tokenAddress) ? 3 : false
   return false
 }
-
-export const sendProposalCreatedEvent = async (
-  network: Network,
-  proposerAddress: string,
-  daoName: string,
-  daoAddress: string
-) => {
-  const url = getEnv(EnvKey.REACT_APP_PROPOSAL_WEBHOOK_URL)
-  const response = await fetch(url, {
-    method: "POST",
-    body: JSON.stringify({
-      network,
-      proposer: proposerAddress,
-      dao_name: daoName,
-      dao_address: daoAddress
-    })
-  })
-  if (!response.ok) {
-    console.error("Failed to send proposal created event", response)
-    return false
-  }
-  return true
-}