Added Subject to access method #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Please note I did not make the change to PseudoFs because the subject is stored as a class member. |
|
Thanks for the patch. Could you add the 'signed-off-by' line in the commit message? |
Access method should check against the caller's RPC credentials. Addresses dCache#71. Signed-off-by: Adam Marcionek <[email protected]>
amarcionek
force-pushed
the
access-subject
branch
from
cb739e9
to
6749f74
Compare
|
@amarcionek The PseudoFS is created per request. This allows to perform all permission check based on different from what file system will allow, like root squashing or request credentials mapping. Give me some time to check that new method nicely plays with existing code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access method should check against the caller's RPC credentials.
Addresses #71.
Signed-off-by: Adam Marcionek [email protected]