Bounds checking: check both lower and upper bounds during node collision resolution #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development of #71, I encountered situations where the
resolveCollisionsBottomToTop
was being called with out-of-bounds values for the function argumenti
.For consistency and safety, this change adds upper and lower bounds checks to both
resolveCollisionsBottomToTop
andresolveCollisionsTopToBottom
.The JSON data in use was:
Revives #80.