Add simulation.randomSource. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would we add the lcg in d3-random then? d3/d3-random#33 |
|
We could, or we could do it here as the default value for simulation.randomSource. |
|
I think it makes more sense in d3-random, but the code is so small it might be better to copy it here and avoid the additional dependency. |
|
I’ve added it to this PR. |
Fil
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
👍
Created a test in https://observablehq.com/d/0db0d022c48d72da that I will pull in when the tests (#177) are merged
|
Sorry to bug you, any chance we could get a minor release with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121.
TODO Default to a linear congruential generator rather than Math.random?Done!