minor

d-reader-organization · May 29, 2024 · 2044297 · 2044297
1 parent 9a2bf55
commit 2044297
Show file tree

Hide file tree

Showing 5 changed files with 53 additions and 110 deletions.
diff --git a/lib/features/discover/root/presentation/widgets/common/discover_scroll_view.dart b/lib/features/discover/root/presentation/widgets/common/discover_scroll_view.dart
@@ -34,118 +34,60 @@ class DiscoverScrollView extends ConsumerWidget {
     required bool isDetailedView,
     required WidgetRef ref,
   }) {
-    // return switch (scrollListType) {
-    //   ScrollListType.comicList => isDetailedView
-    //       ? ComicList(
-    //           provider: ref.read(
-    //             paginatedComicsProvider(
-    //               query,
-    //             ),
-    //           ),
-    //         )
-    //       : ComicGallery(
-    //           provider: ref.read(
-    //             paginatedComicsProvider(
-    //               query,
-    //             ),
-    //           ),
-    //         ),
-    //   ScrollListType.issueList => isDetailedView
-    //       ? IssuesList(
-    //           provider: ref.read(
-    //             paginatedIssuesProvider(
-    //               query,
-    //             ),
-    //           ),
-    //         )
-    //       : IssuesGallery(
-    //           provider: ref.read(
-    //             paginatedIssuesProvider(
-    //               query,
-    //             ),
-    //           ),
-    //         ),
-    //   ScrollListType.creatorList => isDetailedView
-    //       ? CreatorsList(
-    //           provider: ref.read(
-    //             paginatedCreatorsProvider(
-    //               query,
-    //             ),
-    //           ),
-    //         )
-    //       : CreatorsGallery(
-    //           provider: ref.read(
-    //             paginatedCreatorsProvider(
-    //               query,
-    //             ),
-    //           ),
-    //         ),
-    //   ScrollListType.collectiblesList => ComicList(
-    //       provider: ref.read(
-    //         paginatedComicsProvider(
-    //           query,
-    //         ),
-    //       ),
-    //     ),
-    // };
-    switch (scrollListType) {
-      case ScrollListType.comicList:
-        return isDetailedView
-            ? ComicList(
-                provider: ref.read(
-                  paginatedComicsProvider(
-                    query,
-                  ),
+    return switch (scrollListType) {
+      ScrollListType.comicList => isDetailedView
+          ? ComicList(
+              provider: ref.read(
+                paginatedComicsProvider(
+                  query,
                 ),
-              )
-            : ComicGallery(
-                provider: ref.read(
-                  paginatedComicsProvider(
-                    query,
-                  ),
+              ),
+            )
+          : ComicGallery(
+              provider: ref.read(
+                paginatedComicsProvider(
+                  query,
                 ),
-              );
-      case ScrollListType.issueList:
-        return isDetailedView
-            ? IssuesList(
-                provider: ref.read(
-                  paginatedIssuesProvider(
-                    query,
-                  ),
+              ),
+            ),
+      ScrollListType.issueList => isDetailedView
+          ? IssuesList(
+              provider: ref.read(
+                paginatedIssuesProvider(
+                  query,
                 ),
-              )
-            : IssuesGallery(
-                provider: ref.read(
-                  paginatedIssuesProvider(
-                    query,
-                  ),
+              ),
+            )
+          : IssuesGallery(
+              provider: ref.read(
+                paginatedIssuesProvider(
+                  query,
                 ),
-              );
-      case ScrollListType.creatorList:
-        return isDetailedView
-            ? CreatorsList(
-                provider: ref.read(
-                  paginatedCreatorsProvider(
-                    query,
-                  ),
+              ),
+            ),
+      ScrollListType.creatorList => isDetailedView
+          ? CreatorsList(
+              provider: ref.read(
+                paginatedCreatorsProvider(
+                  query,
                 ),
-              )
-            : CreatorsGallery(
-                provider: ref.read(
-                  paginatedCreatorsProvider(
-                    query,
-                  ),
+              ),
+            )
+          : CreatorsGallery(
+              provider: ref.read(
+                paginatedCreatorsProvider(
+                  query,
                 ),
-              );
-      case ScrollListType.collectiblesList:
-        return ComicList(
+              ),
+            ),
+      ScrollListType.collectiblesList => ComicList(
           provider: ref.read(
             paginatedComicsProvider(
               query,
             ),
           ),
-        );
-    }
+        ),
+    };
   }
 
   @override

diff --git a/lib/features/home/presentation/screens/home.dart b/lib/features/home/presentation/screens/home.dart
@@ -49,15 +49,14 @@ class HomeView extends ConsumerWidget {
           ),
         ),
         SliverList(
-          delegate: SliverChildListDelegate(
-            [
-              Container(
-                color: Colors.transparent,
-                padding: const EdgeInsets.only(
+          delegate: SliverChildBuilderDelegate(
+            (context, index) {
+              return const Padding(
+                padding: EdgeInsets.only(
                   left: 16,
                   top: 8.0,
                 ),
-                child: const Column(
+                child: Column(
                   children: [
                     SizedBox(
                       height: 24,
@@ -146,8 +145,9 @@ class HomeView extends ConsumerWidget {
                     ),
                   ],
                 ),
-              ),
-            ],
+              );
+            },
+            childCount: 1,
           ),
         ),
       ],

diff --git a/lib/features/library/presentation/screens/library.dart b/lib/features/library/presentation/screens/library.dart
@@ -59,6 +59,7 @@ class NewLibraryViewState extends ConsumerState<NewLibraryView>
           ),
         ),
         floatHeaderSlivers: true,
+        physics: const BouncingScrollPhysics(),
         headerSliverBuilder: (BuildContext context, bool innerBoxIsScrolled) {
           return [
             SliverToBoxAdapter(

diff --git a/...s/settings/presentation/screens/root.dart → ...ttings/presentation/screens/settings.dart b/...s/settings/presentation/screens/root.dart → ...ttings/presentation/screens/settings.dart
diff --git a/lib/shared/widgets/scaffolds/d_reader_scaffold.dart b/lib/shared/widgets/scaffolds/d_reader_scaffold.dart
@@ -7,7 +7,7 @@ import 'package:d_reader_flutter/shared/theme/app_colors.dart';
 import 'package:d_reader_flutter/features/discover/root/presentation/screens/discover.dart';
 import 'package:d_reader_flutter/features/home/presentation/screens/home.dart';
 import 'package:d_reader_flutter/features/library/presentation/screens/library.dart';
-import 'package:d_reader_flutter/features/settings/presentation/screens/root.dart';
+import 'package:d_reader_flutter/features/settings/presentation/screens/settings.dart';
 import 'package:d_reader_flutter/shared/widgets/layout/custom_bottom_navigation_bar.dart';
 import 'package:d_reader_flutter/shared/widgets/unsorted/test_mode_widget.dart';
 import 'package:d_reader_flutter/features/settings/presentation/widgets/referrals/bottom_navigation.dart';