Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selenium tests broken after bootstrap upgrade #998

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Fix selenium tests broken after bootstrap upgrade #998

merged 9 commits into from
Jul 22, 2024

Conversation

Shadow243
Copy link
Member

Update Selenium Tests to selenium: 4.14.0

This pull request updates the deprecated Selenium tests to use selenium: 4.14.0. As mentioned in the related issue #989, some tests have been commented out temporarily as they are not currently functional, and work is ongoing to address them.

Additionally, the servers.py file will require refactoring to accommodate recent changes, the tests will be updated accordingly to reflect these changes.

@Shadow243 Shadow243 requested a review from kroky May 2, 2024 17:33
@Shadow243 Shadow243 changed the title Fix elenium tests broken after bootstrap upgrade Fix selenium tests broken after bootstrap upgrade May 2, 2024
@Shadow243 Shadow243 force-pushed the fix-selenium branch 4 times, most recently from 57361dc to 5a1ffbb Compare May 2, 2024 18:11
@Shadow243
Copy link
Member Author

Trying to download unavailable version, the latest version here https://googlechromelabs.github.io/chrome-for-testing/#stable is: 124.0.6367.91 but we are trying to download 24.0.6367.118 line https://github.com/cypht-org/cypht/blob/master/.github/tests/selenium/webdriver/webdriver.sh#L3

https://storage.googleapis.com/chrome-for-testing-public/124.0.6367.118/linux64/chromedriver-linux64.zip
Resolving storage.googleapis.com (storage.googleapis.com)... 142.251.163.207, 142.251.167.207, 172.253.115.207, ...
Connecting to storage.googleapis.com (storage.googleapis.com)|142.251.163.207|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-05-02 17:54:24 ERROR 404: Not Found.

  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
Archive:  /tmp/chromedriver-linux64.zip
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/chromedriver-linux64.zip or
        /tmp/chromedriver-linux64.zip.zip, and cannot find /tmp/chromedriver-linux64.zip.ZIP, period.
mv: cannot stat '/tmp/chromedriver-linux64/chromedriver': No such file or directory

@Shadow243 Shadow243 marked this pull request as draft May 2, 2024 18:18
@Shadow243 Shadow243 marked this pull request as ready for review May 6, 2024 16:25
@Shadow243 Shadow243 force-pushed the fix-selenium branch 2 times, most recently from fb87ffd to 97038bb Compare May 6, 2024 16:44
Shadow243
Shadow243 commented May 6, 2024
View reviewed changes
tests/selenium/servers.py Outdated Show resolved Hide resolved
@Shadow243 Shadow243 mentioned this pull request May 6, 2024
Closed
kroky
kroky reviewed May 7, 2024
View reviewed changes
config/app.php Outdated Show resolved Hide resolved
kroky
kroky reviewed May 7, 2024
View reviewed changes
modules/core/output_modules.php Outdated
@@ -314,7 +314,7 @@ class Hm_Output_server_content_start extends Hm_Output_Module {
*/
protected function output() {
return '<div class="content_title">'.$this->trans('Servers').
'<div class="list_controls"></div>'.
// '<div class="list_controls"></div>'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment a temporary thing? If permanent, maybe you just need to remove that line of code.

kroky
kroky reviewed May 7, 2024
View reviewed changes
tests/selenium/inline_msg.py Outdated Show resolved Hide resolved
@kroky
Copy link
Member

kroky commented May 7, 2024

Trying to download unavailable version, the latest version here https://googlechromelabs.github.io/chrome-for-testing/#stable is: 124.0.6367.91 but we are trying to download 24.0.6367.118 line https://github.com/cypht-org/cypht/blob/master/.github/tests/selenium/webdriver/webdriver.sh#L3

https://storage.googleapis.com/chrome-for-testing-public/124.0.6367.118/linux64/chromedriver-linux64.zip
Resolving storage.googleapis.com (storage.googleapis.com)... 142.251.163.207, 142.251.167.207, 172.253.115.207, ...
Connecting to storage.googleapis.com (storage.googleapis.com)|142.251.163.207|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-05-02 17:54:24 ERROR 404: Not Found.

  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
Archive:  /tmp/chromedriver-linux64.zip
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/chromedriver-linux64.zip or
        /tmp/chromedriver-linux64.zip.zip, and cannot find /tmp/chromedriver-linux64.zip.ZIP, period.
mv: cannot stat '/tmp/chromedriver-linux64/chromedriver': No such file or directory

This seems like a temporary repository problem. Can dpkg return more than one available version of a package, so we can try with an older one?

@Shadow243 Shadow243 marked this pull request as draft May 7, 2024 10:35
@Shadow243
Copy link
Member Author

Trying to download unavailable version, the latest version here https://googlechromelabs.github.io/chrome-for-testing/#stable is: 124.0.6367.91 but we are trying to download 24.0.6367.118 line https://github.com/cypht-org/cypht/blob/master/.github/tests/selenium/webdriver/webdriver.sh#L3

https://storage.googleapis.com/chrome-for-testing-public/124.0.6367.118/linux64/chromedriver-linux64.zip
Resolving storage.googleapis.com (storage.googleapis.com)... 142.251.163.207, 142.251.167.207, 172.253.115.207, ...
Connecting to storage.googleapis.com (storage.googleapis.com)|142.251.163.207|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-05-02 17:54:24 ERROR 404: Not Found.

  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
Archive:  /tmp/chromedriver-linux64.zip
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/chromedriver-linux64.zip or
        /tmp/chromedriver-linux64.zip.zip, and cannot find /tmp/chromedriver-linux64.zip.ZIP, period.
mv: cannot stat '/tmp/chromedriver-linux64/chromedriver': No such file or directory

This seems like a temporary repository problem. Can dpkg return more than one available version of a package, so we can try with an older one?

@kroky All versions are available except for Linux:
Screenshot 2024-05-07 at 14 14 27

@Shadow243 Shadow243 force-pushed the fix-selenium branch 8 times, most recently from 38ae5c3 to 9a2d7d0 Compare May 8, 2024 05:11
@Shadow243 Shadow243 force-pushed the fix-selenium branch 22 times, most recently from 5662526 to a423bd5 Compare July 17, 2024 23:45
@Shadow243
Copy link
Member Author

Shadow243 commented Jul 18, 2024 •
edited
Loading

@kroky @marclaporte We managed to restore some selenium tests, I had a suggestion to review and merge this PR then we will create a task which will consist of continuing the resolution of the other tasks (settings.py, inline_msg.py, keyboard_shortcuts.py) which are already working locally but strangely not on github.

@Shadow243 Shadow243 marked this pull request as ready for review July 18, 2024 00:05
@kroky
Copy link
Member

kroky commented Jul 22, 2024

Sounds good.

@kroky kroky merged commit 38c90e0 into cypht-org:master Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroky kroky kroky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shadow243 @kroky @wangxiaoerYah @josaphatim