-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CREATE TABLE statements into config/database.php #983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @PaulTGG. By adding it here, we ensure clarity and ease of location for future reference. However, please be mindful to remove the previous instance at: https://github.com/cypht-org/cypht/blob/master/config/app.php#L618 to avoid duplication.
Where is the best place for that info? Should it be in the app.php, or in the database.php? If the former, then I'll close the PR. If the latter, then the line at the top of database.php mentioning the sql statements should be removed. |
Instinctively, in database.php, especially since there is not too much data there so it is clear and easy to find. |
@Shadow243 app.php is updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, @PaulTGG. Thanks!
@PaulTGG I don't understand why I see 3 commits instead of 2, did you do a local rebase ? |
Yes, there was a non-conflicting commit I added to my fork. (This is my first time contributing to a github project, so I'm still figuring things out... XD) |
Added CREATE TABLE statements into the config/database.php. (The statements are referenced at the top of the file, but they weren't included.)
Oh it's good now I just removed the other commit and then rebase with |
Since we've merged the changes, we'll need to update the documentation accordingly at: https://www.cypht.org/install-2x.html |
Pullrequest
Added CREATE TABLE statement examples into the config/database.php. (The statements are referenced at the start of the file, but they weren't included in the file.)
Issues
Checklist
How2Test
Todo