Fix unremovable text preferences/settings #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I merge this thinking it looked innocent but it is breaking unit tests. I honestly don't know exactly what this change was supposed to fix but I think we need to find another solution. Happy to help if you can explain what the specific issue is! |
|
It's possible to edit values, but not remove (empty) them completely. When you try, they just come back. Seen on "Gmail Client ID" |
|
Thanks for the clarification, pushed a fix to master |
|
Sorry for breaking the tests. I added #596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pullrequest
Updated code to support emptying settings with string values.
Issues