refactor(other): db session locking to support exclusive mode #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow243
force-pushed
the
revamp-db-session-storage
branch
from
518c456
to
02ca4ba
Compare
Shadow243
changed the title
Shadow243
changed the title
Shadow243
changed the title
Shadow243
changed the title
… native file session storage works
Shadow243
force-pushed
the
revamp-db-session-storage
branch
from
02ca4ba
to
2657f72
Compare
kroky
reviewed
Nov 26, 2024
lib/session_db.php
Outdated
| switch ($this->db_driver) { | ||
| case 'mysql': | ||
| $query = 'SELECT GET_LOCK(:lock_name, :timeout)'; | ||
| $params = [':lock_name' => $lock_name, ':timeout' => $this->lock_timeout]; |
There was a problem hiding this comment.
We should implement the lock_timeout in other drivers as well - this is important for concurrent requests. You can use a polling mechanism with intervals of 500ms to 1 second.
There was a problem hiding this comment.
@kroky I just updated, I just did a test with mysql. I'm waiting to see if there are any corrections from you so far before confirming with pgsql too but it should work for pgsql too
kroky
reviewed
Nov 26, 2024
scripts/setup_database.php
Outdated
| $stmt = "{$create_table} hm_user_session (hm_id varchar(255), data longblob, date timestamp, primary key (hm_id));"; | ||
| } elseif($db_driver == 'sqlite') { | ||
| //0 means unlocked, 1 means locked | ||
| $stmt = "{$create_table} hm_user_session (hm_id varchar(255), data longblob, lock INTEGER DEFAULT 0, date timestamp, primary key (hm_id));"; |
There was a problem hiding this comment.
How would existing users update their databases? I think we should introduce some kind of a migration mechanism or handle this in the code.
…etup with column migration logic
Shadow243
force-pushed
the
revamp-db-session-storage
branch
from
4ff8dd5
to
9a6025f
Compare
Shadow243
changed the title
Shadow243
force-pushed
the
revamp-db-session-storage
branch
14 times, most recently
from
4f0632b
to
066c003
Compare
…ssion locking and concurrency
Shadow243
force-pushed
the
revamp-db-session-storage
branch
from
066c003
to
fadddc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task item89272