Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cylon] Arrow 14.0.2 Integration #688

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

arupcsedu
Copy link
Collaborator

  1. Add support for C++17
  2. Update dependent library for conda
  3. Update compatibility issue within arrow.

@cylon-manager
Copy link
Collaborator

cylon-manager commented Apr 18, 2024

@arupcsedu why not use arrow 15.0.x ?

UPDATE: never mind. I think latest cudf is at 14.x.x. So, this should be good

@arupcsedu
Copy link
Collaborator Author

arupcsedu commented Apr 18, 2024 via email

@laszewsk
Copy link
Collaborator

v 15 is a major new release, so i think you want to use 15

https://arrow.apache.org/release/15.0.0.html

@laszewsk
Copy link
Collaborator

is it that cudf, pytorch are not compatible with 15?

@arupcsedu
Copy link
Collaborator Author

arupcsedu commented Apr 18, 2024 via email

Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
@mstaylor mstaylor self-requested a review August 17, 2024 15:39
@mstaylor
Copy link
Collaborator

mstaylor commented Aug 17, 2024

Arup,

Here are some initial suggestions:

  1. Move the rivanna directory and update the necessary scripts under target
  2. Change the conda environments to use cylon_dev as a name
  3. The build completes successfully but there are many warnings that need to be cleaned up. We should have a build process that emits a minimal amount of warning output from the compiler

I'm testing with UCX now and therefore more suggestions may be forthcoming.

@arupcsedu
Copy link
Collaborator Author

arupcsedu commented Aug 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants