Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim unused dependencies #1069

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Trim unused dependencies #1069

merged 2 commits into from
Jul 20, 2022

Conversation

MetRonnie
Copy link
Member

This is a small change with no associated Issue.

Remove direct dependencies on:

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests
  • No change log entry required (invisible to users)
  • No documentation update required.

@MetRonnie MetRonnie added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 20, 2022
@MetRonnie MetRonnie added this to the 1.4.0 milestone Jul 20, 2022
@MetRonnie MetRonnie self-assigned this Jul 20, 2022
oliver-sanders
oliver-sanders approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly the conclusion I'd come to!

@oliver-sanders
Copy link
Member

(letting the tests pass)

@hjoliver hjoliver merged commit af36b1d into cylc:master Jul 20, 2022
@MetRonnie MetRonnie deleted the deps branch July 21, 2022 08:56
@MetRonnie MetRonnie modified the milestones: 1.4.0, 1.3.0 Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@MetRonnie MetRonnie

Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @oliver-sanders @hjoliver