Fix KeyError when using cylc remove after a reload changed the graph
#6516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Dec 5, 2024
MetRonnie
force-pushed
the
cylc-remove
branch
2 times, most recently
from
f6b5e35 to
231f7ee
Compare
MetRonnie
commented
Dec 5, 2024
| @@ -2327,7 +2327,7 @@ def filter_task_proxies( | |||
| ids: Iterable[str], | |||
| warn_no_active: bool = True, | |||
| inactive: bool = False, | |||
| ) -> 'Tuple[List[TaskProxy], Set[Tuple[str, PointBase]], List[str]]': | |||
| ) -> 'Tuple[List[TaskProxy], Set[Tuple[TaskDef, PointBase]], List[str]]': | |||
There was a problem hiding this comment.
One thing to note with this change is that the hashability/equality of TaskDefs is purely reference based (i.e. __hash__() and __eq__() fall back to object default). This should be fine as the TaskDefs are always coming from the scheduler.config.taskdefs dictionary, I believe
MetRonnie
force-pushed
the
cylc-remove
branch
from
231f7ee to
35819a5
Compare
wxtim
approved these changes
Dec 6, 2024
🤣 fair play |
hjoliver
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6502
Unreleased bug. To reproduce:
a & a:started => bwhereais either a long running task or is set to failband reload the workflowcylc remove aKeyErrorwhich crashes the schedulerCheck List
CONTRIBUTING.mdand added my name as a Code Contributor.