-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Merge 8.2.x-sync into master #5913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as well as --workflow-name foo
Ensure that sys argv cleaner cleans up --workflow-name=foo
github-actions
bot
added
the
sync
PR for synchronising changes between 8.*.x and master
label
Jan 10, 2024
* Made execution time limit unsettable by reload or broadcast. Formerly a suppress statement was supressing cases when we wanted to set itask.summary['execution time limit'] = None. Added tests. * response to verbal review * Apply suggestions from code review Co-authored-by: Oliver Sanders <[email protected]> * Prevent false positives in test for broadcast. Test broadcast using _prep_submit_task_job rather than _prep_submit_task_job_impl so that the fake broadcast is applied. * Update changes.d/5902.fix.md Co-authored-by: Hilary James Oliver <[email protected]> * made function less tolerant --------- Co-authored-by: Oliver Sanders <[email protected]> Co-authored-by: Hilary James Oliver <[email protected]>
xtrigger efficiency fix. * Update the DB xtriggers table when the xtriggers get satisfied, not when the tasks that depend on them get satisfied. * Don't delete xtriggers table before every update. --------- Co-authored-by: Oliver Sanders <[email protected]> Co-authored-by: Tim Pillinger <[email protected]>
Update CONTRIBUTING.md
Workflow: Release stage 1 - create release PR (Cylc 8+ only), run: 31
Co-authored-by: Oliver Sanders <[email protected]>
Prepare release: 8.2.4
Workflow: Release stage 2 - auto publish, run: 67
🤖 Bump dev version
wxtim
previously approved these changes
Jan 11, 2024
Lint check failing on a single broken link, which actually seems to be down right now. Manylinux checks are failing. Trying on master. https://github.com/cylc/cylc-flow/actions/runs/7500207009 |
wxtim
reviewed
Jan 12, 2024
oliver-sanders
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do a normal merge, not squash merge.
Please fix conflicts if necessary.
Triggered by
schedule