Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Merge 8.2.x-sync into master #5913

Merged
merged 14 commits into from
Jan 12, 2024
Merged

🤖 Merge 8.2.x-sync into master #5913

merged 14 commits into from
Jan 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Please do a normal merge, not squash merge.
Please fix conflicts if necessary.


Triggered by schedule

@github-actions github-actions bot added the sync PR for synchronising changes between 8.*.x and master label Jan 10, 2024
wxtim and others added 8 commits January 11, 2024 13:43
* Made execution time limit unsettable by reload or broadcast.
Formerly a suppress statement was supressing cases when we
wanted to set itask.summary['execution time limit'] = None.

Added tests.

* response to verbal review

* Apply suggestions from code review

Co-authored-by: Oliver Sanders <[email protected]>

* Prevent false positives in test for broadcast.
Test broadcast using _prep_submit_task_job
rather than _prep_submit_task_job_impl so that
the fake broadcast is applied.

* Update changes.d/5902.fix.md

Co-authored-by: Hilary James Oliver <[email protected]>

* made function less tolerant

---------

Co-authored-by: Oliver Sanders <[email protected]>
Co-authored-by: Hilary James Oliver <[email protected]>
xtrigger efficiency fix.

* Update the DB xtriggers table when the xtriggers get satisfied, not
  when the tasks that depend on them get satisfied.
* Don't delete xtriggers table before every update.

---------

Co-authored-by: Oliver Sanders <[email protected]>
Co-authored-by: Tim Pillinger <[email protected]>
Workflow: Release stage 1 - create release PR (Cylc 8+ only), run: 31
Co-authored-by: Oliver Sanders <[email protected]>
Workflow: Release stage 2 - auto publish, run: 67
@wxtim wxtim requested a review from oliver-sanders January 11, 2024 16:08
wxtim
wxtim previously approved these changes Jan 11, 2024
@wxtim
Copy link
Member

wxtim commented Jan 12, 2024

Lint check failing on a single broken link, which actually seems to be down right now.

Manylinux checks are failing. Trying on master. https://github.com/cylc/cylc-flow/actions/runs/7500207009

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@wxtim wxtim self-requested a review January 12, 2024 14:11
@oliver-sanders oliver-sanders merged commit c07392d into master Jan 12, 2024
34 of 38 checks passed
@oliver-sanders oliver-sanders deleted the 8.2.x-sync branch January 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync PR for synchronising changes between 8.*.x and master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants