tests/i: add reflog fixture #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Possible counter-example: async def test_reflog(flow, scheduler, run, reflog, complete):
id_ = flow({
'scheduler': {
'allow implicit tasks': 'true'
},
'scheduling': {
'graph': {
'R1': 'foo:failed => bar'
}
},
})
schd = scheduler(id_, paused_start=False)
async with run(schd):
triggers = reflog(schd)
await complete(schd)
breakpoint(header=f'{triggers=}')
assert triggers == {
('1/foo', None),
('1/bar', ('1/foo',)), # This may well not be right, but we're not getting any trigger at all here
} |
|
This example should hang because you haven't configured Try setting |
Try |
oliver-sanders
requested review from
MetRonnie
and removed request for
hjoliver
MetRonnie
reviewed
Nov 27, 2023
oliver-sanders
force-pushed
the
reflog
branch
2 times, most recently
from
6cc9477 to
2b9476e
Compare
MetRonnie
reviewed
Nov 28, 2023
|
Would be very surprised if chaing TZ made Tui tests unstable? Will take a look at them once I've cleared my bug backlog. |
This was referenced Dec 4, 2023
* Add an itegration test pattern for implementing reference tests.
* We were using the pytest-env plugin to run the tests in a non-UTC time zone. * The pytest-env plugin doesn't work with pytest-xdist so this was being ignored. * Also due to the way TZ support works in Python, changing the env var whilst Python is running may or may not result in changes.
Co-authored-by: Ronnie Dutta <[email protected]>
oliver-sanders
force-pushed
the
reflog
branch
from
5a27190 to
de7cb17
Compare
|
Got to the bottom of the test failure, it's caused by a bug in simulation mode fixed on #5721 I've put in a temporary patch which can be removed in or after that PR depending on merge order. |
oliver-sanders
commented
Dec 13, 2023
| # https://github.com/cylc/cylc-flow/pull/5721 | ||
| 'root': { | ||
| 'simulation': { | ||
| 'default run length': 'PT1M', |
There was a problem hiding this comment.
The patch, short runtimes could cause tasks to go through running & succeeded even whilst the workflow is paused.
oliver-sanders
commented
Dec 13, 2023
| @@ -3,11 +3,11 @@ | |||
| <span style="color:#000000;background:#e5e5e5">│</span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5">Path: mypath </span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5">│</span> | |||
| <span style="color:#000000;background:#e5e5e5">│</span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5"><</span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#e5e5e5;background:#000000">S</span><span style="color:#000000;background:#e5e5e5">elect File </span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5">></span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5">│</span> | |||
| <span style="color:#000000;background:#e5e5e5">│</span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5">│</span> | |||
| <span style="color:#000000;background:#e5e5e5">│</span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5">[runtime] </span><span style="color:#000000;background:#e5e5e5"> </span><span style="color:#000000;background:#e5e5e5">│</span> | |||
There was a problem hiding this comment.
The order of the [scheduling] and [runtime] sections of the config changed as a result of prepending the default simulation runtime.
|
Manylinux failures are unrelated, see this run on master: https://github.com/cylc/cylc-flow/actions/runs/7197952698 |
wxtim
approved these changes
Dec 14, 2023
MetRonnie
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a reflog fixture to the integration tests for trigger testing.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.