Merge pull request #3370 from dwsutherland/sort_key_camel

Allow camel or snake sort key
cylc · Sep 18, 2019 · c86e3c5 · c86e3c5
2 parents 287ead8 + ba60af6
commit c86e3c5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cylc/flow/network/resolvers.py b/cylc/flow/network/resolvers.py
@@ -18,6 +18,7 @@
 
 from operator import attrgetter
 from fnmatch import fnmatchcase
+from graphene.utils.str_converters import to_snake_case
 
 from cylc.flow.ws_data_mgr import (
     ID_DELIM, EDGES, FAMILY_PROXIES, TASK_PROXIES, WORKFLOW)
@@ -145,7 +146,7 @@ def sort_elements(elements, args):
     if sort_args and elements:
         sort_keys = [
             key
-            for key in sort_args.keys
+            for key in [to_snake_case(k) for k in sort_args.keys]
             if hasattr(elements[0], key)
         ]
         if sort_keys:

diff --git a/cylc/flow/network/schema.py b/cylc/flow/network/schema.py
@@ -143,7 +143,7 @@ def parse_node_id(item, node_type=None):
 # Field args (i.e. for queries etc):
 class SortArgs(InputObjectType):
     keys = List(String, default_value=['id'])
-    reverse = Boolean()
+    reverse = Boolean(default_value=False)
 
 
 jobs_args = dict(