Skip to content

Commit

Permalink
Log job failure even when it does not cause a change in task state.
Browse files Browse the repository at this point in the history
  • Loading branch information
wxtim committed Jun 25, 2024
1 parent d715aff commit 8f20ab0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions changes.d/fix.6169.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ensure that job failure is logged, even when the presence of retries causes the task not to change state.
2 changes: 1 addition & 1 deletion cylc/flow/task_events_mgr.py
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,7 @@ def _process_message_check(
# gets logged by itask state change anyway (and not manual poll)
if severity_lvl > DEBUG and flag != self.FLAG_POLLED and message in {
self.EVENT_SUBMITTED, self.EVENT_STARTED, self.EVENT_SUCCEEDED,
self.EVENT_SUBMIT_FAILED, f'{FAIL_MESSAGE_PREFIX}ERR'
self.EVENT_SUBMIT_FAILED
}:
severity_lvl = DEBUG
LOG.log(severity_lvl, f"[{itask}] {flag}{message}{timestamp}")
Expand Down

0 comments on commit 8f20ab0

Please sign in to comment.