New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sender generates keys with partial secret #44

Merged

cygnet3 merged 2 commits into cygnet3:master from Sosthene00:partial_secret

Sep 17, 2023

Contributor

Sosthene00 commented Sep 15, 2023

Closes #38


          Sender generates keys with partial secret

fd452b2

Owner

cygnet3 commented Sep 16, 2023

Looks good, two points:

the decode_scan_pubkey function was used at first to get the scan key to calculate the ecdh_shared_secret. Since we now give the partial secret, I think we should remove this function too
Can you fix the unused import warning?


          Remove decode_scan_pubkey function

0f298ae

cygnet3 merged commit 36d28c0 into cygnet3:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet