Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR-182] Add file counts to meta data #4

Merged
merged 11 commits into from
Nov 13, 2023
Merged

[RFR-182] Add file counts to meta data #4

merged 11 commits into from
Nov 13, 2023

Conversation

hb0
Copy link
Contributor

@hb0 hb0 commented Oct 26, 2023 •
edited
Loading

This PR mostly:

  • removes the old, deprecated authentication code from this libary
  • adds the support for the new (attachment) files upload/endpoint

@hb0 hb0 self-assigned this Oct 26, 2023
@hb0 hb0 force-pushed the task/LEIP-164_image-transmission branch 4 times, most recently from 2a6547c to fbf1922 Compare October 31, 2023 11:25
@hb0 hb0 force-pushed the task/LEIP-164_image-transmission branch from fbf1922 to cd1cf0f Compare October 31, 2023 12:03
hb0
hb0 commented Oct 31, 2023
View reviewed changes
Copy link
Contributor Author

@hb0 hb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-reviewed

build.gradle.kts Outdated Show resolved Hide resolved
src/main/kotlin/de/cyface/uploader/Authenticator.kt Outdated Show resolved Hide resolved
src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Show resolved Hide resolved
src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Show resolved Hide resolved
src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Outdated Show resolved Hide resolved
src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Show resolved Hide resolved
@hb0 hb0 requested a review from muthenberg October 31, 2023 12:11
@hb0 hb0 marked this pull request as ready for review October 31, 2023 12:14
muthenberg
muthenberg requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@muthenberg muthenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments inline

src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Outdated Show resolved Hide resolved
src/main/kotlin/de/cyface/uploader/RequestInitializeHandler.kt Outdated Show resolved Hide resolved
src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Show resolved Hide resolved
src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Show resolved Hide resolved
@hb0 hb0 force-pushed the task/LEIP-164_image-transmission branch 2 times, most recently from 2a1d077 to cc27b95 Compare November 2, 2023 08:15
@hb0 hb0 force-pushed the task/LEIP-164_image-transmission branch from cc27b95 to d8e98ee Compare November 2, 2023 08:34
hb0
hb0 commented Nov 2, 2023
View reviewed changes
Copy link
Contributor Author

@hb0 hb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my replies / commits

src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Show resolved Hide resolved
src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Outdated Show resolved Hide resolved
muthenberg
muthenberg requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@muthenberg muthenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

src/main/kotlin/de/cyface/uploader/DefaultUploader.kt Outdated Show resolved Hide resolved
@hb0 hb0 merged commit 2e92563 into main Nov 13, 2023
1 check passed
@hb0 hb0 deleted the task/LEIP-164_image-transmission branch November 13, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthenberg muthenberg muthenberg requested changes

Assignees

@hb0 hb0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hb0 @muthenberg