Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attachmentId to RequestMetaData #58

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Add attachmentId to RequestMetaData #58

merged 3 commits into from
Jul 15, 2024

Conversation

hb0
Copy link
Contributor

@hb0 hb0 commented Jun 4, 2024 •
edited
Loading

Update:

This PR removes the RequestMetaData as the upload requests have nothing to do with the purpose of this library, which is the serialization of the binary data. The upoader library should have it's own copy of this model instead.

@hb0 hb0 requested a review from muthenberg June 4, 2024 15:43
@hb0 hb0 self-assigned this Jun 4, 2024
muthenberg
muthenberg requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@muthenberg muthenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments inline. I think some kind of abstraction is necessary to find the common ground between measurements and attachments handle both cleanly together, or if that is not possible, separate handling them.

libs/model/src/main/kotlin/de/cyface/model/RequestMetaData.kt Outdated Show resolved Hide resolved
libs/model/src/main/kotlin/de/cyface/model/RequestMetaData.kt Outdated Show resolved Hide resolved
@hb0 hb0 force-pushed the task/RFR-1057_add-attachments-support branch 2 times, most recently from e5a027d to 77bc75b Compare June 24, 2024 12:18
hb0
hb0 commented Jun 24, 2024
View reviewed changes
Copy link
Contributor Author

@hb0 hb0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to fix the code smell

libs/model/src/main/java/de/cyface/model/MeasurementIdentifier.java Outdated Show resolved Hide resolved
libs/model/src/main/kotlin/de/cyface/model/RequestMetaData.kt Outdated Show resolved Hide resolved
libs/model/src/main/kotlin/de/cyface/model/RequestMetaData.kt Outdated Show resolved Hide resolved
libs/model/src/main/kotlin/de/cyface/model/RequestMetaData.kt Outdated Show resolved Hide resolved
@hb0 hb0 force-pushed the task/RFR-1057_add-attachments-support branch from 77bc75b to 3d00726 Compare June 24, 2024 15:32
@hb0 hb0 force-pushed the task/RFR-1057_add-attachments-support branch from 3d00726 to 7bbaba4 Compare June 24, 2024 15:34
@hb0 hb0 marked this pull request as ready for review June 25, 2024 13:36
@hb0 hb0 merged commit 5d067c0 into main Jul 15, 2024
1 check passed
@hb0 hb0 deleted the task/RFR-1057_add-attachments-support branch July 15, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthenberg muthenberg muthenberg requested changes

Assignees

@hb0 hb0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hb0 @muthenberg