Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/rfr 733 filter invalid locations #53

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Task/rfr 733 filter invalid locations #53

merged 8 commits into from
Sep 28, 2023

Conversation

hb0
Copy link
Contributor

@hb0 hb0 commented Sep 26, 2023 •
edited
Loading

Use commit-wise review or else you see the Kotlin conversions.

@hb0 hb0 self-assigned this Sep 26, 2023
@hb0 hb0 requested a review from muthenberg September 27, 2023 10:32
muthenberg
muthenberg requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@muthenberg muthenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All together not very complex. But please have a look if an idiomatic Kotlin solution is possible here.

libs/model/src/main/kotlin/de/cyface/model/CalibrationJob.kt Outdated Show resolved Hide resolved
libs/model/src/main/kotlin/de/cyface/model/Track.kt Outdated Show resolved Hide resolved
@hb0 hb0 merged commit 30ef3a3 into main Sep 28, 2023
@hb0 hb0 deleted the task/RFR-733_filter-invalid-locations branch September 28, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthenberg muthenberg muthenberg requested changes

Assignees

@hb0 hb0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hb0 @muthenberg