-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/aws: Added support for 'ssocreds' #295
base: master
Are you sure you want to change the base?
Conversation
By adding the provider to the list of Providers to check for credentials
When can this be merged? Is there anything that needs to be done? |
@joh-klein could you test the PR and confirm this works for you? |
I tried it – it does not work for me at all. It just says |
Alright so we'll need to update it to avoid having several credential required between SSO/access/secret key, etc |
any updates? |
I'm asking the OPS to enable SSO so I can test it. Though I see what I did wrong. AWS expects the SSO provider initialization to have the values you have on the file so they can request the AccessKey/SecretKey, so I do not have to remove the requirement of those as internally I set them from the fetcher. But the implementation is not correct as I'm not reading the file, I was expecting the lib to do it as we have for shared credentials, so what should be done is to fetch the file first, read the values, initialize the sso provider and then call the For this I have to find a public method on the AWS lib (fond a private one for now) that reads the config raw and then I can read the values from it so i can initialize the the sso Provider correctly. That's where I'm now, If I find the method then It should be farely easy to implement I think. I'm looking into it but it's not my main priority tbh, but I'm looking into it :). |
By adding the provider to the list of Providers to check for credentials
Closes #282