Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/aws: Added support for 'ssocreds' #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmd/aws: Added support for 'ssocreds' #295

wants to merge 1 commit into from

Conversation

xescugc
Copy link
Member

@xescugc xescugc commented May 23, 2022

By adding the provider to the list of Providers to check for credentials

Closes #282

By adding the provider to the list of Providers to check for credentials
@xescugc xescugc self-assigned this May 23, 2022
@xescugc xescugc mentioned this pull request May 23, 2022
@joh-klein
Copy link

joh-klein commented Jun 27, 2022

When can this be merged? Is there anything that needs to be done?

@xlr-8
Copy link
Contributor

xlr-8 commented Jun 28, 2022

@joh-klein could you test the PR and confirm this works for you?

@joh-klein
Copy link

I tried it – it does not work for me at all. It just says the flag "access-key" is required. When I removed the "access-key is required" check, it failed with Error: could not initialize 'reader' because: EmptyStaticCreds: static credentials are empty.

@xlr-8
Copy link
Contributor

xlr-8 commented Jun 29, 2022

Alright so we'll need to update it to avoid having several credential required between SSO/access/secret key, etc

@Hokwang
Copy link

Hokwang commented Jul 25, 2022

any updates?

@xescugc
Copy link
Member Author

xescugc commented Jul 25, 2022

I'm asking the OPS to enable SSO so I can test it.

Though I see what I did wrong. AWS expects the SSO provider initialization to have the values you have on the file so they can request the AccessKey/SecretKey, so I do not have to remove the requirement of those as internally I set them from the fetcher.

But the implementation is not correct as I'm not reading the file, I was expecting the lib to do it as we have for shared credentials, so what should be done is to fetch the file first, read the values, initialize the sso provider and then call the .Retrieve() which returns the Value which has the Access/Secret.

For this I have to find a public method on the AWS lib (fond a private one for now) that reads the config raw and then I can read the values from it so i can initialize the the sso Provider correctly.

That's where I'm now, If I find the method then It should be farely easy to implement I think. I'm looking into it but it's not my main priority tbh, but I'm looking into it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SSO
4 participants