Switch to biome tags for biome-based entity spawning. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use biome tags for entity spawning - Remove farm animals from `minecraft:is_jungle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
minecraft:is_jungleWith the former, I'm mostly just hoping to start a conversation about finding a way to use vanilla and conventional biome tags to achieve better compatibility with biome mods. Both types of biome tag have seen a lot of improvements over the past year or so, and now conventional tags are largely standardized between fabric/quilt and neoforge. Biome modders have been encouraged to use more biome tags, and even if all Faunus did for biome mod compatibility was to use biome tags, I think the compatibility would be pretty good. This also allows biome mods to further refine compatibility with Faunus by modifying the Faunus spawn tags.
I don't know how important it is having the biomes in the configuration; I have taken the easy road of removing that functionality, but another (more technically difficult) path might be to allow tags in the configuration instead. For example, this PR makes Faunus compatible with the Terraformers biome mods (Traverse and Terrestria in the overworld).
As for the latter change, all it does is turn on the existing functionality to remove the mods from biomes tagged
minecraft:is_jungle. I did this because when we discussed in Discord it sounded like having it turned off might have been an oversight. It does appear to work, although passive spawns are slow, so it is hard to really confirm. I think this feature is best left turned off unless biome tags are also being used for mob additions (as in this PR).