Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kleene star followup #196

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Kleene star followup #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fef13ed
Add test cases, add the property graph not exists to pass test
Dtenwolde Jan 9, 2025
60f8627
Update ref to duckdb
Dtenwolde Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion duckdb
Open in desktop
Submodule duckdb updated 5 files
+22 −59 third_party/libpg_query/grammar/statements/pgq.y
+1 −1 third_party/libpg_query/grammar/types/pgq.yh
+6 −0 third_party/libpg_query/scan.l
+20,028 −20,064 third_party/libpg_query/src_backend_parser_gram.cpp
+20 −14 third_party/libpg_query/src_backend_parser_scan.cpp
2 changes: 1 addition & 1 deletion test/sql/path_finding/kleene_star.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ statement error
COLUMNS (n1.id, n2.id, element_id(p), edges(p) AS path_edges, path_length(p))
);
----
Parser Error: PGQ expected an arrow instead of *< operator. at or near "*<"
Parser Error: syntax error at or near "*<"

statement error
-FROM GRAPH_TABLE(testgraph
Expand Down
121 changes: 121 additions & 0 deletions test/sql/path_finding/parser_arrow_kleene.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@


require duckpgq

statement ok
CREATE TABLE nodes (id INTEGER); INSERT INTO nodes VALUES (1), (2), (3);

statement ok
CREATE TABLE edges (src INTEGER, dst INTEGER);

statement ok
-CREATE PROPERTY GRAPH testgraph
VERTEX TABLES (
nodes LABEL N
)
EDGE TABLES (
edges SOURCE KEY (src) REFERENCES nodes (id)
DESTINATION KEY (dst) REFERENCES nodes (id)
LABEL E
);

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E]->*(n2:N));

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E]-> *(n2:N));

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E]- > *(n2:N));

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E] - > *(n2:N));

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E] -> *(n2:N));

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E]< -> *(n2:N));
----
Parser Error: syntax error at or near "<"

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E] /-> *(n2:N));
----
Parser Error: syntax error at or near "/->"

# Not yet supported
statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-> *(n2:N));
----
Constraint Error: All patterns must bind to a label

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[]-> *(n2:N));
----
Constraint Error: All patterns must bind to a label

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[]- > *(n2:N));
----
Constraint Error: All patterns must bind to a label

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e2:E] > *(n2:N));
----
Parser Error: syntax error at or near ">"

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E]*(n2:N));
----
Parser Error: syntax error at or near "*"

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E]- > *(n2:N));

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)-[e:E]<- *(n2:N));
----
Parser Error: syntax error at or near "<"

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)<-> *(n2:N));
----
Constraint Error: All patterns must bind to a label

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)< - > *(n2:N));
----
Constraint Error: All patterns must bind to a label

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)<- *(n2:N));
----
Constraint Error: All patterns must bind to a label

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)< - *(n2:N));
----
Constraint Error: All patterns must bind to a label

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)< -*(n2:N));
----
Constraint Error: All patterns must bind to a label

statement error
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)< -?(n2:N));
----
Constraint Error: All patterns must bind to a label

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)<-[e1:E]-?(n2:N));

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)<-[e1:E] - ?(n2:N));

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)<-[e1:E] -> ?(n2:N));

statement ok
-FROM GRAPH_TABLE (testgraph MATCH ANY SHORTEST (n1:N)<-[e1:E] - >?(n2:N));
Loading