Fix query on unspecified property #191
Open
+173
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/fix-undefined-property
branch
from
a40b949 to
a78a05d
Compare
dentiny
force-pushed
the
hjiang/fix-undefined-property
branch
from
a78a05d to
491af18
Compare
dentiny
commented
Dec 25, 2024
| @@ -948,11 +1080,16 @@ PGQMatchFunction::MatchBindReplace(ClientContext &context, | |||
| if (ref->where_clause) { | |||
| conditions.push_back(std::move(ref->where_clause)); | |||
| } | |||
|
|
|||
| CheckColumnBinding(*pg_table, *ref); | |||
There was a problem hiding this comment.
Having an additional validation function, instead of splitting and baking the validation logic into the multiple for loops seem to make code cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #190
The core idea for this PR is to get all columns in the property graph, and check whether the column to query is accessible or not.