Add readme on query prefix #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
commented
Dec 16, 2024
| @@ -241,6 +245,9 @@ The main binaries that will be built are: | |||
| ## Running the extension | |||
| To run the extension code, simply start the shell with `./build/release/duckdb`. | |||
|
|
|||
| > [!CAUTION] | |||
There was a problem hiding this comment.
I copy the exact word from https://duckpgq.notion.site/Building-DuckPGQ-619783a5af604efbb7c93f09811d996f
Closed
2 tasks
Dtenwolde
approved these changes
Dec 16, 2024
|
Thanks for the PR, I agree that this info should also be in the README.md. I added some more information on the binaries produced by the build. |
Thanks! Should be included in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue comment #179 (comment), I personally think it's better to add some clarification at project
READMEdoc :)