Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-op] Clang format all files #175

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Dec 6, 2024

Disclaimer:

  • All these changes are generated automatically by clang-format.
  • The existing code seems good at most of the places, but weirdly formatted in other places, not sure if we already have a coding style? (just want to get myself a little familiar with the toolchain)

clang-format is widely used in other duckdb ecosystem projects:

It seems make format is already integrated in our toolchain, though I haven't figured out where it's implemented.
This is the screenshot and command I executed:

(base) ubuntu@hjiang-devbox-pg:~/duckpgq-extension$ make format
find src/ -iname *.hpp -o -iname *.cpp | xargs clang-format --sort-includes=0 -style=file -i
cmake-format -i CMakeLists.txt

@Dtenwolde
Copy link
Contributor

Thanks for the PR! I haven't been too mindful of using make format for my PRs but will in the future :) I think this would actually be good to add to the CI/CD so I'll work on a related PR to add that
The make format rule is defined here: https://github.com/duckdb/extension-ci-tools/blob/27facd3b63aa4c7c23e80e726851db132f1db264/makefiles/duckdb_extension.Makefile#L135

@dentiny
Copy link
Contributor Author

dentiny commented Dec 9, 2024

Thanks for the PR! I haven't been too mindful of using make format for my PRs but will in the future :) I think this would actually be good to add to the CI/CD so I'll work on a related PR to add that The make format rule is defined here: https://github.com/duckdb/extension-ci-tools/blob/27facd3b63aa4c7c23e80e726851db132f1db264/makefiles/duckdb_extension.Makefile#L135

That makes sense, thanks for the code pointer!

@Dtenwolde Dtenwolde merged commit fb38a09 into cwida:main Dec 9, 2024
35 checks passed
@Dtenwolde
Copy link
Contributor

Thanks for the PR! I haven't been too mindful of using make format for my PRs but will in the future :) I think this would actually be good to add to the CI/CD so I'll work on a related PR to add that The make format rule is defined here: duckdb/extension-ci-tools@27facd3/makefiles/duckdb_extension.Makefile#L135

That makes sense, thanks for the code pointer!

I submitted a PR duckdb/extension-ci-tools#120

@dentiny
Copy link
Contributor Author

dentiny commented Dec 10, 2024

Thanks you so much for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants