Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation via move #173

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Dec 2, 2024

I met a few compilation failures, for example:

/home/ubuntu/duckpgq-extension/src/core/functions/function_data/weakly_connected_component_function_data.cpp:33:10: error: could not convert 'result' from 'unique_ptr<duckpgq::core::WeaklyConnectedComponentFunctionData,default_delete<duckpgq::core::WeaklyConnectedComponentFunctionData>,[...]>' to 'unique_ptr<duckdb::FunctionData,default_delete<duckdb::FunctionData>,[...]>'
   33 |   return result;
      |          ^~~~~~
      |          |
      |          unique_ptr<duckpgq::core::WeaklyConnectedComponentFunctionData,default_delete<duckpgq::core::WeaklyConnectedComponentFunctionData>,[...]>

Similar to the issue raised in pg_duckdb: duckdb/pg_duckdb#455

@dentiny dentiny mentioned this pull request Dec 2, 2024
2 tasks
@Dtenwolde
Copy link
Contributor

Hi there, thanks for the PR! I wasn't aware of these build failures but thank you for fixing them :)

@Dtenwolde Dtenwolde merged commit 3db82c2 into cwida:main Dec 2, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants