Extension now also works in python environment #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dtenwolde
deleted the
100-parser-extension-doesnt-work-in-python-environment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #100 🎉
You need to explicitly load the extension in Python, which I forgot about. This PR adds a simple test that works through
make test_pythonTo debug pyTest > Edit configurations > Environment variables:
Name
DUCKPGQ_EXTENSION_BINARY_PATHValue
~/git/duckpgq/build/debug/extension/duckpgq/duckpgq.duckdb_extensionWorking directory should be
~/git/duckpgq/test/pythonReady for debug