Merge pull request #152 from cwida/46-seg-fault-when-doing-topk-queries

Fix segmentation fault when doing top k queries
cwida · Oct 9, 2024 · f00f1cf · f00f1cf
2 parents 386cc7d + 87d1df5
commit f00f1cf
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 1 deletion.
diff --git a/duckdb b/duckdb
diff --git a/test/sql/path_finding/top_k.test b/test/sql/path_finding/top_k.test
@@ -0,0 +1,57 @@
+# name: test/sql/path_finding/top_k.test
+# description: Testing top-k functionality, not implemented yet.
+# group: [duckpgq_sql_path_finding]
+
+require duckpgq
+
+statement ok
+CREATE TABLE Student(id BIGINT, name VARCHAR); INSERT INTO Student VALUES (0, 'Daniel'), (1, 'Tavneet'), (2, 'Gabor'), (3, 'Peter'), (4, 'David');
+
+statement ok
+CREATE TABLE know(src BIGINT, dst BIGINT, createDate BIGINT); INSERT INTO know VALUES (0,1, 10), (0,2, 11), (0,3, 12), (3,0, 13), (1,2, 14), (1,3, 15), (2,3, 16), (4,3, 17);
+
+statement ok
+-CREATE PROPERTY GRAPH pg
+VERTEX TABLES (
+    Student LABEL person
+    )
+EDGE TABLES (
+    know    SOURCE KEY ( src ) REFERENCES Student ( id )
+            DESTINATION KEY ( dst ) REFERENCES Student ( id )
+            label knows
+    );
+
+statement error
+-FROM GRAPH_TABLE (pg
+    MATCH
+    p = ANY SHORTEST 5 WALK (a:Person)-[k:knows]-> *(b:Person)
+    WHERE a.name = 'Daniel'
+    COLUMNS (p, a.name as name, b.name as school)
+    ) study;
+----
+Parser Error: syntax error at or near "5"
+
+
+statement error
+-FROM GRAPH_TABLE (pg
+        MATCH
+        p =  SHORTEST 5 (a:Person)-[k:knows]-> *(b:Person)
+        WHERE a.name = 'Daniel');
+----
+Not implemented Error: TopK has not been implemented yet.
+
+statement error
+-FROM GRAPH_TABLE (pg
+        MATCH
+        p =  SHORTEST 5 WALK (a:Person)-[k:knows]-> *(b:Person)
+        WHERE a.name = 'Daniel');
+----
+Not implemented Error: TopK has not been implemented yet.
+
+statement error
+-FROM GRAPH_TABLE (pg
+        MATCH
+        p =  ANY SHORTEST 5 WALK (a:Person)-[k:knows]-> *(b:Person)
+        WHERE a.name = 'Daniel');
+----
+Parser Error: syntax error at or near "5"
+2 −0		src/parser/transform/tableref/transform_match.cpp
+34 −23		third_party/libpg_query/grammar/statements/pgq.y
+1,444 −1,433		third_party/libpg_query/src_backend_parser_gram.cpp