Merge with v0.10.2

.clang-tidy

@@ -1,7 +1,6 @@
-Checks:          '-*,clang-diagnostic-*,bugprone-*,performance-*,google-explicit-constructor,google-build-using-namespace,google-runtime-int,misc-definitions-in-headers,modernize-use-nullptr,modernize-use-override,-bugprone-macro-parentheses,readability-braces-around-statements,-bugprone-branch-clone,readability-identifier-naming,hicpp-exception-baseclass,misc-throw-by-value-catch-by-reference,-bugprone-signed-char-misuse,-bugprone-misplaced-widening-cast,-bugprone-sizeof-expression,-bugprone-narrowing-conversions,-bugprone-easily-swappable-parameters,google-global-names-in-headers,llvm-header-guard,misc-definitions-in-headers,modernize-use-emplace,modernize-use-bool-literals,-performance-inefficient-string-concatenation,-performance-no-int-to-ptr,readability-container-size-empty,cppcoreguidelines-pro-type-cstyle-cast'
+Checks:          '-*,clang-diagnostic-*,bugprone-*,performance-*,google-explicit-constructor,google-build-using-namespace,google-runtime-int,misc-definitions-in-headers,modernize-use-nullptr,modernize-use-override,-bugprone-macro-parentheses,readability-braces-around-statements,-bugprone-branch-clone,readability-identifier-naming,hicpp-exception-baseclass,misc-throw-by-value-catch-by-reference,-bugprone-signed-char-misuse,-bugprone-misplaced-widening-cast,-bugprone-sizeof-expression,-bugprone-narrowing-conversions,-bugprone-easily-swappable-parameters,google-global-names-in-headers,llvm-header-guard,misc-definitions-in-headers,modernize-use-emplace,modernize-use-bool-literals,-performance-inefficient-string-concatenation,-performance-no-int-to-ptr,readability-container-size-empty,cppcoreguidelines-pro-type-cstyle-cast,-llvm-header-guard,-performance-enum-size,cppcoreguidelines-pro-type-const-cast,cppcoreguidelines-avoid-non-const-global-variables,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-slicing,cppcoreguidelines-rvalue-reference-param-not-moved,cppcoreguidelines-virtual-class-destructor'
 WarningsAsErrors: '*'
-HeaderFilterRegex: '.*^(re2.h)'
-AnalyzeTemporaryDtors: false
+HeaderFilterRegex: 'src/include/duckdb/.*'
 FormatStyle:     none
 CheckOptions:
   - key:             readability-identifier-naming.ClassCase
@@ -37,7 +36,7 @@ CheckOptions:
   - key:             readability-identifier-naming.EnumConstantCase
     value:           UPPER_CASE
   - key:             readability-identifier-naming.ConstexprVariableCase
-    value:           UPPER_CASE
+    value:           aNy_CasE
   - key:             readability-identifier-naming.StaticConstantCase
     value:           UPPER_CASE
   - key:             readability-identifier-naming.TemplateTemplateParameterCase
@@ -48,4 +47,6 @@ CheckOptions:
     value:           lower_case
   - key:             modernize-use-emplace.SmartPointers
     value:           '::std::shared_ptr;::duckdb::unique_ptr;::std::auto_ptr;::std::weak_ptr'
+  - key:             cppcoreguidelines-rvalue-reference-param-not-moved.IgnoreUnnamedParams
+    value:           true
 

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -16,13 +16,16 @@ body:
             * [duckdb-wasm](https://github.com/duckdb/duckdb-wasm/issues/new)
             * [go-duckdb](https://github.com/marcboeker/go-duckdb/issues/new)
           * Extensions:
+            * [Arrow extension](https://github.com/duckdb/duckdb_arrow/issues/new)
             * [AWS extension](https://github.com/duckdb/duckdb_aws/issues/new)
             * [Azure extension](https://github.com/duckdb/duckdb_azure/issues/new)
             * [Iceberg extension](https://github.com/duckdb/duckdb_iceberg/issues/new)
             * [MySQL extension](https://github.com/duckdb/duckdb_mysql/issues/new)
             * [Postgres scanner](https://github.com/duckdb/postgres_scanner/issues/new)
             * [Spatial extension](https://github.com/duckdb/duckdb_spatial/issues/new)
             * [SQLite scanner](https://github.com/duckdb/sqlite_scanner/issues/new)
+          * Connectors:
+            * [dbt-duckdb](https://github.com/duckdb/dbt-duckdb)
 
         If none of the above repositories are applicable, feel free to raise it in this one
 
@@ -38,7 +41,7 @@ body:
   - type: textarea
     attributes:
       label: To Reproduce
-      description: Steps to reproduce the behavior. Please paste the code and the output as text, and avoid using screenshots. Please use [code blocks](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks) for formatting and add the required imports for Python scripts (e.g., import duckdb). Bonus points if the steps only include SQL queries.
+      description: Steps to reproduce the behavior, preferably a [minimal reproducible example](https://en.wikipedia.org/wiki/Minimal_reproducible_example). Please format the code and the output as [code blocks](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks) and add the required imports for scripts (e.g., `import duckdb`). Bonus points if the steps only include SQL queries.
     validations:
       required: true
 
@@ -86,25 +89,42 @@ body:
       value: |
         If the above is not given and is not obvious from your GitHub profile page, we might close your issue without further review. Please refer to the [reasoning behind this rule](https://berthub.eu/articles/posts/anonymous-help/) if you have questions.
 
-        # Before Submitting
+        # Before Submitting:
 
   - type: dropdown
     attributes:
-      label: Have you tried this on the latest [nightly build](https://duckdb.org/docs/installation/?version=main)?
+      label: What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.
       description: |
-        * **Python**: `pip install duckdb --upgrade --pre`
-        * **R**: `install.packages('duckdb', repos=c('https://duckdb.r-universe.dev', 'https://cloud.r-project.org'))`
-        * **Other Platforms**: You can find links to binaries [here](https://duckdb.org/docs/installation/) or compile from source.
+        Visit the [installation page](https://duckdb.org/docs/installation/) for instructions.
       options:
-        - I have tested with a nightly build
-        - I have tested with a release build (and could not test with a nightly build)
         - I have not tested with any build
+        - I have tested with a stable release
+        - I have tested with a nightly build
+        - I have tested with a source build
     validations:
       required: true
 
+  - type: dropdown
+    attributes:
+      label: Did you include all relevant data sets for reproducing the issue?
+      options:
+        - "No - Other reason (please specify in the issue body)"
+        - "No - I cannot share the data sets because they are confidential"
+        - "No - I cannot easily share my data sets due to their large size"
+        - "Not applicable - the reproduction does not require a data set"
+        - "Yes"
+      default: 0
+    validations:
+      required: true
+
+  - type: checkboxes
+    attributes:
+      label: Did you include all code required to reproduce the issue?
+      options:
+        - label: Yes, I have
+
   - type: checkboxes
     attributes:
-      label: Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?
+      label: Did you include all relevant configuration (e.g., CPU architecture, Python version, Linux distribution) to reproduce the issue?
       options:
         - label: Yes, I have
-          required: true

.github/config/extensions.csv

@@ -7,11 +7,12 @@ json,,,
 parquet,,,
 tpcds,,,
 tpch,,,
-sqlite_scanner,https://github.com/duckdb/sqlite_scanner,c1343464ef4397665b858db9c193d33fac591b1c,
-postgres_scanner,https://github.com/duckdb/postgres_scanner,375710fd22a35107b2c28e744f787e1a93a99998,
+sqlite_scanner,https://github.com/duckdb/sqlite_scanner,091197efb34579c7195afa43dfb5925023c915c0,
+postgres_scanner,https://github.com/duckdb/postgres_scanner,96206f41d5ca7015920a66b54e936c986fe0b0f8,
 substrait,https://github.com/duckdb/substrait,1116fb580edd3e26e675436dbdbdf4a0aa5e456e,no-windows
 arrow,https://github.com/duckdb/arrow,9e10240da11f61ea7fbfe3fc9988ffe672ccd40f,no-windows
 aws,https://github.com/duckdb/duckdb_aws,f7b8729f1cce5ada5d4add70e1486de50763fb97,
-azure,https://github.com/duckdb/duckdb_azure,86f39d76157de970d16d6d6537bc90c0ee1c7d35,
-spatial,https://github.com/duckdb/duckdb_spatial,05c4ba01c500140287bf6946fb6910122e5c2acf,
-iceberg,https://github.com/duckdb/duckdb_iceberg,7aa3d8e4cb7b513d35fdacfa28dc328771bc4047,
+azure,https://github.com/duckdb/duckdb_azure,09623777a366572bfb8fa53e47acdf72133a360e,
+spatial,https://github.com/duckdb/duckdb_spatial,8ac803e986ccda34f32dee82a7faae95b72b3492,
+iceberg,https://github.com/duckdb/duckdb_iceberg,d89423c2ff90a0b98a093a133c8dfe2a55b9e092,
+vss,https://github.com/duckdb/duckdb_vss,8145f41d97178e82bed3376215eb8d02bcf1eec5,

.github/config/out_of_tree_extensions.cmake

@@ -4,9 +4,19 @@
 # to build duckdb with this configuration run:
 #   EXTENSION_CONFIGS=.github/config/out_of_tree_extensions.cmake make
 #
+#  Note that many of these packages require vcpkg, and a merged manifest must be created to
+#  compile multiple of them.
+#
+#  After setting up vcpkg, build using e.g. the following commands:
+#  USE_MERGED_VCPKG_MANIFEST=1 BUILD_ALL_EXT=1 make extension_configuration
+#  USE_MERGED_VCPKG_MANIFEST=1 BUILD_ALL_EXT=1 make debug
+#
+#  Make sure the VCPKG_TOOLCHAIN_PATH and VCPKG_TARGET_TRIPLET are set. For example:
+#  VCPKG_TOOLCHAIN_PATH=~/vcpkg/scripts/buildsystems/vcpkg.cmake
+#  VCPKG_TARGET_TRIPLET=arm64-osx
 
 ################# ARROW
-if (NOT WIN32)
+if (NOT MINGW)
     duckdb_extension_load(arrow
             LOAD_TESTS DONT_LINK
             GIT_URL https://github.com/duckdb/arrow
@@ -28,7 +38,7 @@ if (NOT MINGW)
     duckdb_extension_load(azure
             LOAD_TESTS
             GIT_URL https://github.com/duckdb/duckdb_azure
-            GIT_TAG 86f39d76157de970d16d6d6537bc90c0ee1c7d35
+            GIT_TAG 09623777a366572bfb8fa53e47acdf72133a360e
             )
 endif()
 
@@ -44,7 +54,7 @@ if (NOT MINGW)
     duckdb_extension_load(iceberg
             ${LOAD_ICEBERG_TESTS}
             GIT_URL https://github.com/duckdb/duckdb_iceberg
-            GIT_TAG 7aa3d8e4cb7b513d35fdacfa28dc328771bc4047
+            GIT_TAG d89423c2ff90a0b98a093a133c8dfe2a55b9e092
             )
 endif()
 
@@ -55,20 +65,18 @@ if (NOT MINGW)
     duckdb_extension_load(postgres_scanner
             DONT_LINK
             GIT_URL https://github.com/duckdb/postgres_scanner
-            GIT_TAG 375710fd22a35107b2c28e744f787e1a93a99998
+            GIT_TAG 96206f41d5ca7015920a66b54e936c986fe0b0f8
             )
 endif()
 
 ################# SPATIAL
-if (NOT MINGW)
-    duckdb_extension_load(spatial
-            DONT_LINK LOAD_TESTS
-            GIT_URL https://github.com/duckdb/duckdb_spatial.git
-            GIT_TAG 05c4ba01c500140287bf6946fb6910122e5c2acf
-            INCLUDE_DIR spatial/include
-            TEST_DIR test/sql
-            )
-endif()
+duckdb_extension_load(spatial
+    DONT_LINK LOAD_TESTS
+    GIT_URL https://github.com/duckdb/duckdb_spatial.git
+    GIT_TAG 8ac803e986ccda34f32dee82a7faae95b72b3492
+    INCLUDE_DIR spatial/include
+    TEST_DIR test/sql
+    )
 
 ################# SQLITE_SCANNER
 # Static linking on windows does not properly work due to symbol collision
@@ -81,7 +89,7 @@ endif()
 duckdb_extension_load(sqlite_scanner
         ${STATIC_LINK_SQLITE} LOAD_TESTS
         GIT_URL https://github.com/duckdb/sqlite_scanner
-        GIT_TAG c1343464ef4397665b858db9c193d33fac591b1c
+        GIT_TAG 091197efb34579c7195afa43dfb5925023c915c0
         )
 
 ################# SUBSTRAIT
@@ -92,3 +100,12 @@ if (NOT WIN32)
             GIT_TAG 1116fb580edd3e26e675436dbdbdf4a0aa5e456e
             )
 endif()
+
+
+################# VSS
+duckdb_extension_load(vss
+        LOAD_TESTS
+        GIT_URL https://github.com/duckdb/duckdb_vss
+        GIT_TAG 8145f41d97178e82bed3376215eb8d02bcf1eec5
+        TEST_DIR test/sql
+    )

.github/workflows/CheckIssueForCodeFormatting.yml

@@ -6,7 +6,7 @@ on:
 
 env:
   GH_TOKEN: ${{ secrets.DUCKDBLABS_BOT_TOKEN }}
-
+  ISSUE_BODY: ${{ github.event.issue.body }}
 jobs:
   check_code_formatting:
     runs-on: ubuntu-latest
@@ -20,9 +20,7 @@ jobs:
           python-version: '3.11'
       - name: Check issue for code formatting
         run: |
-          cat << 'EOF' >> issue-text.md
-          ${{ github.event.issue.body }}"
-          EOF
+          echo "$ISSUE_BODY" >> issue-text.md
           if ! cat issue-text.md | python3 scripts/check-issue-for-code-formatting.py; then
               gh issue comment ${{ github.event.issue.number }} --body-file .github/workflows/code-formatting-warning.md
           fi