Skip to content
This repository has been archived by the owner on Aug 29, 2022. It is now read-only.

Add client improvements such as refreshing access and editing. #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

swichers
Copy link

  • Adds OAuth refresh token support.
  • Enables uploading files larger than text and small files.
  • Implements some missing endpoint functionality:
    • getActiveXmpFields: Gets the available XMP fields.
    • queueAssetDownload: Queues asset preset for download.
    • downloadFromQueue: Downloads an asset preset.
    • editAsset: Edits an existing asset's properties.
    • editAssetXmpMetadata: Edit an existing asset's metadata.

@cweagans
Copy link
Owner

All of this stuff could probably use some unit tests. There's already a pretty comprehensive test suite -- can you add to that?

@swichers
Copy link
Author

I know this is a very old PR. For anyone landing here, this project does not have a comprehensive test suite. It has the illusion of one. All of the tests only check this method https://github.com/cweagans/php-webdam-client/blob/master/src/Entity/Asset.php#L147= which is basically a reimplementation of JsonSerializable, but worse.

This code has been in use on the Acquia version of this package for years without issue. The Acquia version of this package is also the one that receives updates. The changes are bundled with the Acquia DAM Drupal module.

https://git.drupalcode.org/project/media_acquiadam/-/blob/8.x-1.x/src/Client.php

Acquia was in the process of getting ownership of this repository transferred to them (they were the ones that originally paid for its development), but it looks like that never happened.

If you are a user of Webdam I would recommend contacting Acquia and asking them to publish a public version of this client library within their own namespace and integrating their updates.

@cweagans
Copy link
Owner

Not sure I was ever asked about transferring ownership to Acquia. Happy to do that if there's interest in taking over maintenance.

@swichers
Copy link
Author

swichers commented Jun 28, 2022

You and I spoke directly about it after some time a while back. I passed it off to the DAM product owner on if they wanted to maintain fork, take complete ownership, make it public/private, white-label, etc. If they don't care by now 🤷 I'm not invested in the future of this package (left the DAM team a long time back, and Acquia last year), I just wanted to provide information for others who find themselves here via Google (and clean up my outstanding Github items)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants