Regression forecaster #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can not merge b/c pylint score is lowered too much by RegressionMeanReturn test class, and I do not want to drop it. Will have to finish it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#126 is too big and focused on adapting rest of library to improved forecasters (with the new exponential smoothing and moving average forecasters). That will be merged first, and this will contain work to expand forecasters to also take arbitrary regressors.
Goal: merge #126, hopefully work this one out soon-ish so we make a single release (1.3.0). Could end up in 1.4.0.
Initially forecasters will be passed as simple dataframes (fixed at time of instantiation) and marked as experimental (not covered by semantic versioning). Then we'll figure out how to define them symbolically.